1. 23 Aug, 2020 1 commit
  2. 06 May, 2020 5 commits
    • Nick Mathewson's avatar
      Use __attribute__((fallthrough)) rather than magic GCC comments. · c1167282
      Nick Mathewson authored
      GCC added an implicit-fallthrough warning a while back, where it
      would complain if you had a nontrivial "case:" block that didn't end
      with break, return, or something like that.  Clang recently added
      the same thing.
      
      GCC, however, would let you annotate a fall-through as intended by
      any of various magic "/* fall through */" comments.  Clang, however,
      only seems to like "__attribute__((fallthrough))".  Fortunately, GCC
      accepts that too.
      
      A previous commit in this branch defined a FALLTHROUGH macro to do
      the right thing if GNUC is defined; here we replace all of our "fall
      through" comments with uses of that macro.
      
      This is an automated commit, made with the following perl one-liner:
      
        #!/usr/bin/perl -i -p
        s#/\* *falls? ?thr.*?\*/#FALLTHROUGH;#i;
      
      (In order to avoid conflicts, I'm applying this script separately to
      each maint branch. This is the 0.4.3 version.)
      c1167282
    • Nick Mathewson's avatar
      Use __attribute__((fallthrough)) rather than magic GCC comments. · 28ac17f4
      Nick Mathewson authored
      GCC added an implicit-fallthrough warning a while back, where it
      would complain if you had a nontrivial "case:" block that didn't end
      with break, return, or something like that.  Clang recently added
      the same thing.
      
      GCC, however, would let you annotate a fall-through as intended by
      any of various magic "/* fall through */" comments.  Clang, however,
      only seems to like "__attribute__((fallthrough))".  Fortunately, GCC
      accepts that too.
      
      A previous commit in this branch defined a FALLTHROUGH macro to do
      the right thing if GNUC is defined; here we replace all of our "fall
      through" comments with uses of that macro.
      
      This is an automated commit, made with the following perl one-liner:
      
        #!/usr/bin/perl -i -p
        s#/\* *falls? ?thr.*?\*/#FALLTHROUGH;#i;
      
      (In order to avoid conflicts, I'm applying this script separately to
      each maint branch. This is the 0.4.2 version.)
      28ac17f4
    • Nick Mathewson's avatar
      Use __attribute__((fallthrough)) rather than magic GCC comments. · 79ff2b6a
      Nick Mathewson authored
      GCC added an implicit-fallthrough warning a while back, where it
      would complain if you had a nontrivial "case:" block that didn't end
      with break, return, or something like that.  Clang recently added
      the same thing.
      
      GCC, however, would let you annotate a fall-through as intended by
      any of various magic "/* fall through */" comments.  Clang, however,
      only seems to like "__attribute__((fallthrough))".  Fortunately, GCC
      accepts that too.
      
      A previous commit in this branch defined a FALLTHROUGH macro to do
      the right thing if GNUC is defined; here we replace all of our "fall
      through" comments with uses of that macro.
      
      This is an automated commit, made with the following perl one-liner:
      
        #!/usr/bin/perl -i -p
        s#/\* *falls? ?thr.*?\*/#FALLTHROUGH;#i;
      
      (In order to avoid conflicts, I'm applying this script separately to
      each maint branch. This is the 0.4.1 version.)
      79ff2b6a
    • Nick Mathewson's avatar
      Use __attribute__((fallthrough)) rather than magic GCC comments. · cc397449
      Nick Mathewson authored
      GCC added an implicit-fallthrough warning a while back, where it
      would complain if you had a nontrivial "case:" block that didn't end
      with break, return, or something like that.  Clang recently added
      the same thing.
      
      GCC, however, would let you annotate a fall-through as intended by
      any of various magic "/* fall through */" comments.  Clang, however,
      only seems to like "__attribute__((fallthrough))".  Fortunately, GCC
      accepts that too.
      
      A previous commit in this branch defined a FALLTHROUGH macro to do
      the right thing if GNUC is defined; here we replace all of our "fall
      through" comments with uses of that macro.
      
      This is an automated commit, made with the following perl one-liner:
      
        #!/usr/bin/perl -i -p
        s#/\* *falls? ?thr.*?\*/#FALLTHROUGH;#i;
      cc397449
    • Nick Mathewson's avatar
      include compat_compiler for ed25519_donna · 37b8324e
      Nick Mathewson authored
      37b8324e
  3. 09 Jan, 2019 1 commit
    • Kris Katterjohn's avatar
      Fix (and make consistent) the use of OpenBSD preprocessor macro tests · c13a81f7
      Kris Katterjohn authored and Nick Mathewson's avatar Nick Mathewson committed
      Prior to this commit, the testsuite was failing on OpenBSD.  After
      this commit the testsuite runs fine on OpenBSD.
      
      It was previously decided to test for the OpenBSD macro (rather than
      __OpenBSD__, etc.) because OpenBSD forks seem to have the former
      macro defined.  sys/param.h must be included for the OpenBSD macro
      definition; however, many files tested for the OpenBSD macro without
      having this header included.
      
      This commit includes sys/param.h in the files where the OpenBSD macro
      is used (and sys/param.h is not already included), and it also
      changes some instances of the __OpenBSD__ macro to OpenBSD.
      
      See commit 27df23ab
      
       which changed
      everything to use OpenBSD instead of __OpenBSD__ or OPENBSD.  See
      also tickets #6982 and #20980 (the latter ticket is where it was
      decided to use the OpenBSD macro).
      Signed-off-by: default avatarKris Katterjohn <katterjohn@gmail.com>
      c13a81f7
  4. 11 Sep, 2018 1 commit
  5. 21 Jun, 2018 2 commits
  6. 20 Jun, 2018 1 commit
  7. 06 Apr, 2018 1 commit
  8. 07 Feb, 2018 1 commit
  9. 03 Feb, 2018 1 commit
  10. 11 Sep, 2017 2 commits
  11. 09 Aug, 2017 1 commit
    • George Kadianakis's avatar
      Don't double hash the ed25519 blind key parameter. · 4ad4467f
      George Kadianakis authored and Nick Mathewson's avatar Nick Mathewson committed
      We used to do:
         h = H(BLIND_STRING | H(A | s | B | N )
      when we should be doing:
         h = H(BLIND_STRING | A | s | B | N)
      
      Change the logic so that hs_common.c does the hashing, and our ed25519
      libraries just receive the hashed parameter ready-made. That's easier
      than doing the hashing on the ed25519 libraries, since that means we
      would have to pass them a variable-length param (depending on whether
      's' is set or not).
      
      Also fix the ed25519 test vectors since they were also double hashing.
      4ad4467f
  12. 27 Jul, 2017 1 commit
  13. 28 Jun, 2017 1 commit
  14. 27 Jun, 2017 1 commit
  15. 31 May, 2017 1 commit
  16. 30 May, 2017 1 commit
  17. 31 Mar, 2017 1 commit
  18. 28 Jul, 2016 1 commit
  19. 11 Jun, 2016 4 commits
    • Nick Mathewson's avatar
      Fix build on 32-bit systems. · 47edbd4f
      Nick Mathewson authored
      47edbd4f
    • Nick Mathewson's avatar
      Add -Wmissing-variable-declarations, with attendant fixes · 53a3b39d
      Nick Mathewson authored
      This is a big-ish patch, but it's very straightforward.  Under this
      clang warning, we're not actually allowed to have a global variable
      without a previous extern declaration for it.  The cases where we
      violated this rule fall into three roughly equal groups:
        * Stuff that should have been static.
        * Stuff that was global but where the extern was local to some
          other C file.
        * Stuff that was only global when built for the unit tests, that
          needed a conditional extern in the headers.
      
      The first two were IMO genuine problems; the last is a wart of how
      we build tests.
      53a3b39d
    • Nick Mathewson's avatar
      Use autoconf, not gcc version, to decide which warnings we have · 9bbd6502
      Nick Mathewson authored
      This gives more accurate results under Clang, which can only help us
      detect more warnings in more places.
      
      Fixes bug 19216; bugfix on 0.2.0.1-alpha
      9bbd6502
    • Nick Mathewson's avatar
      Add -Wunused-const-variable=2 on GCC >=6.1 · 2ff20c93
      Nick Mathewson authored
      This caused a trivial warning in curve25519-donna-64bit.h, which
      had two unused constants.  I commented them out.
      2ff20c93
  20. 15 Apr, 2016 1 commit
  21. 24 Feb, 2016 1 commit
  22. 08 Dec, 2015 1 commit
  23. 16 Sep, 2015 1 commit
    • Sebastian Hahn's avatar
      Don't enable SSE2 on X86-64. · 98da122a
      Sebastian Hahn authored
      This removes a comment presumably introduced for debugging that was left
      in accidentally. Bug not in any released version of Tor. Fixes bug
      17092.
      98da122a
  24. 04 Sep, 2015 1 commit
  25. 01 Sep, 2015 1 commit
  26. 17 Aug, 2015 2 commits
  27. 12 Aug, 2015 1 commit
  28. 27 Jul, 2015 1 commit
    • Yawning Angel's avatar
      Fix ed25519-donna with SSP on non-x86. · c0106118
      Yawning Angel authored
      The only reason 16 byte alignment is required is for SSE2 load and
      store operations, so only align datastructures to 16 byte boundaries
      when building with SSE2 support.
      
      This fixes builds with GCC SSP on platforms that don't have special
      case code to do dynamic stack re-alignment (everything not x86/x86_64).
      
      Fixes bug #16666.
      c0106118
  29. 12 Jul, 2015 2 commits