GitLab

With the maximum likelihood estimator for alpha from #40168, we no longer need
max_time to calculate alpha.

This is still fast enough. ~100usec on my laptop with 1000 build times.

50ms is not enough resolution. CBT can be as low as 80ms in datacenter
clients close to their relays.

This should allow us to more accurately estimate pareto parameters
without relying on "right-censorship" of circuit build timeout values.

This prevents the timeout curve from getting spread out as much, resulting in
more accurate timeout values for quantiles from 60-80.

"ours" to avoid version bump.

Fixes #25528
Signed-off-by: David Goulet <dgoulet@torproject.org>

When sending the stream level SENDME, it is possible the cirucit was marked
for close or any other failures that can occur. These events can occur
naturally.

Fixes #40142
Signed-off-by: David Goulet <dgoulet@torproject.org>

The function in charge of removing duplicate ORPorts from our configured ports
was skipping all non ORPorts port but only for the outer loop thus resulting
in comparing an ORPort with a non-ORPort which lead to problems.

For example, tor configured with the following would fail:

  ORPort auto
  DirPort auto

Both end up being the same configuration except that one is a OR listener and
one is a Dir listener. Thus because of the missing check in the inner loop,
they looked exactly the same and thus one is removed.

Fixes #40195
Signed-off-by: David Goulet <dgoulet@torproject.org>