1. 09 Jan, 2019 1 commit
    • Kris Katterjohn's avatar
      Fix (and make consistent) the use of OpenBSD preprocessor macro tests · c13a81f7
      Kris Katterjohn authored and Nick Mathewson's avatar Nick Mathewson committed
      Prior to this commit, the testsuite was failing on OpenBSD.  After
      this commit the testsuite runs fine on OpenBSD.
      
      It was previously decided to test for the OpenBSD macro (rather than
      __OpenBSD__, etc.) because OpenBSD forks seem to have the former
      macro defined.  sys/param.h must be included for the OpenBSD macro
      definition; however, many files tested for the OpenBSD macro without
      having this header included.
      
      This commit includes sys/param.h in the files where the OpenBSD macro
      is used (and sys/param.h is not already included), and it also
      changes some instances of the __OpenBSD__ macro to OpenBSD.
      
      See commit 27df23ab
      
       which changed
      everything to use OpenBSD instead of __OpenBSD__ or OPENBSD.  See
      also tickets #6982 and #20980 (the latter ticket is where it was
      decided to use the OpenBSD macro).
      
      Signed-off-by: default avatarKris Katterjohn <katterjohn@gmail.com>
      c13a81f7
  2. 10 Jul, 2018 1 commit
  3. 05 Jul, 2018 1 commit
    • Nick Mathewson's avatar
      Remove util.h · 45938298
      Nick Mathewson authored
      Inline its contents (which were all includes) into or.h, and some of
      its contents into other places that didn't include or.h at all.
      45938298
  4. 29 Jun, 2018 1 commit
  5. 21 Jun, 2018 1 commit
  6. 20 Jun, 2018 2 commits
  7. 06 Apr, 2018 1 commit
  8. 27 Oct, 2017 1 commit
  9. 21 Aug, 2017 1 commit
  10. 03 Feb, 2017 1 commit
  11. 08 Sep, 2016 1 commit
  12. 06 Sep, 2016 1 commit
    • Nick Mathewson's avatar
      checkSpace.pl now forbids more identifiers. · 5927ed8d
      Nick Mathewson authored
      The functions it warns about are:
        assert, memcmp, strcat, strcpy, sprintf, malloc, free, realloc,
        strdup, strndup, calloc.
      
      Also, fix a few lingering instances of these in the code. Use other
      conventions to indicate _intended_ use of assert and
      malloc/realloc/etc.
      5927ed8d
  13. 28 Jul, 2016 1 commit
  14. 11 Jun, 2016 1 commit
    • Nick Mathewson's avatar
      Add -Wmissing-variable-declarations, with attendant fixes · 53a3b39d
      Nick Mathewson authored
      This is a big-ish patch, but it's very straightforward.  Under this
      clang warning, we're not actually allowed to have a global variable
      without a previous extern declaration for it.  The cases where we
      violated this rule fall into three roughly equal groups:
        * Stuff that should have been static.
        * Stuff that was global but where the extern was local to some
          other C file.
        * Stuff that was only global when built for the unit tests, that
          needed a conditional extern in the headers.
      
      The first two were IMO genuine problems; the last is a wart of how
      we build tests.
      53a3b39d
  15. 25 Apr, 2016 1 commit
    • Nick Mathewson's avatar
      Remove redundant declarations of MIN · bff53aab
      Nick Mathewson authored
      Apparently somewhere along the line we decided that MIN might be
      missing.
      
      But we already defined it (if it was missing) in compat.h, which
      everybody includes.
      
      Closes ticket 18889.
      bff53aab
  16. 15 Dec, 2015 1 commit
  17. 29 May, 2015 1 commit
  18. 30 Apr, 2015 1 commit
  19. 15 Apr, 2015 1 commit
  20. 19 Mar, 2015 1 commit
    • Nick Mathewson's avatar
      Here is a test for memwipe. · e82e600d
      Nick Mathewson authored
      It invokes undefined behavior, I'm afraid, since there's no other
      c-legal way to test whether memwipe() works when we're not allowed to
      look at it.
      
      Closes ticket 15377.
      e82e600d