1. 19 Aug, 2020 39 commits
    • Georg Koppen's avatar
      e052bd2a
    • Richard Pospesel's avatar
      Bug 23247: Communicating security expectations for .onion · d074ef0f
      Richard Pospesel authored and Georg Koppen's avatar Georg Koppen committed
      Encrypting pages hosted on Onion Services with SSL/TLS is redundant
      (in terms of hiding content) as all traffic within the Tor network is
      already fully encrypted.  Therefore, serving HTTP pages from an Onion
      Service is more or less fine.
      
      Prior to this patch, Tor Browser would mostly treat pages delivered
      via Onion Services as well as pages delivered in the ordinary fashion
      over the internet in the same way.  This created some inconsistencies
      in behaviour and misinformation presented to the user relating to the
      security of pages delivered via Onion Services:
      
       - HTTP Onion Service pages did not have any 'lock' icon indicating
         the site was secure
       - HTTP Onion Service pages would be marked as unencrypted in the Page
         Info screen
       - Mixed-mode content restrictions did not apply to HTTP Onion Service
         pages embedding Non-Onion HTTP content
      
      This patch fixes the above issues, and also adds several new 'Onion'
      icons to the mix to indicate all of the various permutations of Onion
      Services hosted HTTP or HTTPS pages with HTTP or HTTPS content.
      
      Strings for Onion Service Page Info page are pulled from Torbutton's
      localization strings.
      d074ef0f
    • Alex Catarineu's avatar
      Bug 28369: Stop shipping pingsender executable · 6e077925
      Alex Catarineu authored and Georg Koppen's avatar Georg Koppen committed
      6e077925
    • Arthur Edelstein's avatar
      Bug 26353: Prevent speculative connect that violated FPI. · bbfa6145
      Arthur Edelstein authored and Georg Koppen's avatar Georg Koppen committed
      Connections were observed in the catch-all circuit when
      the user entered an https or http URL in the URL bar, or
      typed a search term.
      bbfa6145
    • Richard Pospesel's avatar
      Bug 25658: Replace security slider with security level UI · 89411b80
      Richard Pospesel authored and Georg Koppen's avatar Georg Koppen committed
      This patch adds a new 'securitylevel' component to Tor Browser intended
      to replace the torbutton 'Security Slider'.
      
      This component adds a new Security Level toolbar button which visually
      indicates the current global security level via icon (as defined by the
      extensions.torbutton.security_slider pref), a drop-down hanger with a
      short description of the current security level, and a new section in
      the about:preferences#privacy page where users can change their current
      security level. In addition, the hanger and the preferences page will
      show a visual warning when the user has modified prefs associated with
      the security level and provide a one-click 'Restore Defaults' button to
      get the user back on recommended settings.
      
      Strings used by this patch are pulled from the torbutton extension, but
      en-US defaults are provided if there is an error loading from the
      extension. With this patch applied, the usual work-flow of "./mach build
      && ./mach run" work as expected, even if the torbutton extension is
      disabled.
      89411b80
    • Igor Oliveira's avatar
      Bug 23104: Add a default line height compensation · 1caa5b7b
      Igor Oliveira authored and Georg Koppen's avatar Georg Koppen committed
      Many fonts have issues with their vertical metrics. they
      are used to influence the height of ascenders and depth
      of descenders. Gecko uses it to calculate the line height
      (font height + ascender + descender), however because of
      that idiosyncratic behavior across multiple operating
      systems, it can be used to identify the user's OS.
      
      The solution proposed in the patch uses a default factor
      to be multiplied with the font size, simulating the concept
      of ascender and descender. This way all operating
      systems will have the same line height only and only if the
      frame is outside the chrome.
      1caa5b7b
    • Georg Koppen's avatar
      Bug 21830: Copying large text from web console leaks to /tmp · b7403427
      Georg Koppen authored
      Patch written by Neill Miller
      b7403427
    • Kathleen Brade's avatar
      Bug 21431: Clean-up system extensions shipped in Firefox · 87a50675
      Kathleen Brade authored and Georg Koppen's avatar Georg Koppen committed
      Only ship the pdfjs extension.
      87a50675
    • Georg Koppen's avatar
      Bug 16285: Exclude ClearKey system for now · 367d5ad1
      Georg Koppen authored
      In the past the ClearKey system had not been compiled when specifying
      --disable-eme. But that changed and it is even bundled nowadays (see:
      Mozilla's bug 1300654). We don't want to ship it right now as the use
      case for it is not really visible while the code had security
      vulnerabilities in the past.
      367d5ad1
    • boklm's avatar
      Bug 21907: Fix runtime error on CentOS 6 · c14b502f
      boklm authored and Georg Koppen's avatar Georg Koppen committed
      In Mozilla bug 1324780, support for building with glib 2.28 (the version
      available in CentOS 6) was added. However we are building on Debian
      Wheezy which has glib 2.32. We fix that by backing out all glib > 2.28
      code paths.
      c14b502f
    • Mike Perry's avatar
      Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing · 26819e83
      Mike Perry authored and Georg Koppen's avatar Georg Koppen committed
      eBay and Amazon don't treat Tor users very well. Accounts often get locked and
      payments reversed.
      
      Also:
      Bug 16322: Update DuckDuckGo search engine
      
      We are replacing the clearnet URL with an onion service one (thanks to a
      patch by a cypherpunk) and are removing the duplicated DDG search
      engine. Duplicating DDG happend due to bug 1061736 where Mozilla
      included DDG itself into Firefox. Interestingly, this caused breaking
      the DDG search if JavaScript is disabled as the Mozilla engine, which
      gets loaded earlier, does not use the html version of the search page.
      Moreover, the Mozilla engine tracked where the users were searching from
      by adding a respective parameter to the search query. We got rid of that
      feature as well.
      
      Also:
      This fixes bug 20809: the DuckDuckGo team has changed its server-side
      code in a way that lets users with JavaScript enabled use the default
      landing page while those without JavaScript available get redirected
      directly to the non-JS page. We adapt the search engine URLs
      accordingly.
      
      Also fixes bug 29798 by making sure we only specify the Google search
      engine we actually ship an .xml file for.
      
      Also regression tests.
      26819e83
    • Kathleen Brade's avatar
      Bug 16940: After update, load local change notes. · ad7c2c03
      Kathleen Brade authored and Georg Koppen's avatar Georg Koppen committed
      Add an about:tbupdate page that displays the first section from
      TorBrowser/Docs/ChangeLog.txt and includes a link to the remote
      post-update page (typically our blog entry for the release).
      
      Always load about:tbupdate in a content process, but implement the
      code that reads the file system (changelog) in the chrome process
      for compatibility with future sandboxing efforts.
      
      Also fix bug 29440. Now about:tbupdate is styled as a fairly simple
      changelog page that is designed to be displayed via a link that is on
      about:tor.
      ad7c2c03
    • Kathleen Brade's avatar
      Bug 13379: Sign our MAR files. · fc4042bc
      Kathleen Brade authored and Georg Koppen's avatar Georg Koppen committed
      Configure with --enable-verify-mar (when updating, require a valid
        signature on the MAR file before it is applied).
      Use the Tor Browser version instead of the Firefox version inside the
        MAR file info block (necessary to prevent downgrade attacks).
      Use NSS on all platforms for checking MAR signatures (instead of using
        OS-native APIs, which Mozilla does on Mac OS and Windows). So that the
        NSS and NSPR libraries the updater depends on can be found at runtime,
        we add the firefox directory to the shared library search path on macOS.
        On Linux, rpath is used by Mozilla to solve that problem, but that
        approach won't work on macOS because the updater executable is copied
        during the update process to a location that is under TorBrowser-Data,
        and the location of TorBrowser-Data varies.
      
      Also includes the fix for bug 18900.
      fc4042bc
    • Kathleen Brade's avatar
      Bug 4234: Use the Firefox Update Process for Tor Browser. · 775556ba
      Kathleen Brade authored and Georg Koppen's avatar Georg Koppen committed
      The following files are never updated:
        TorBrowser/Data/Browser/profiles.ini
        TorBrowser/Data/Browser/profile.default/bookmarks.html
        TorBrowser/Data/Tor/torrc
      Mac OS: Store update metadata under TorBrowser/UpdateInfo.
      Removed the %OS_VERSION% component from the update URL (13047) and
        added support for minSupportedOSVersion, an attribute of the
        <update> element that may be used to trigger Firefox's
        "unsupported platform" behavior.
      Hide the "What's new" links (set app.releaseNotesURL value to about:blank).
      Windows: disable "runas" code path in updater (15201).
      Windows: avoid writing to the registry (16236).
      Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406,
        16014, 16909, 24476, and 25909.
      
      Also fix Bug 26049: reduce the delay before the update prompt is displayed.
      Instead of Firefox's 2 days, we use 1 hour (after which time the update
      doorhanger will be displayed).
      
      Also fix bug 27221: purge the startup cache if the Tor Browser
      version changed (even if the Firefox version and build ID did
      not change), e.g., after a minor Tor Browser update.
      
      Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality.
      
      Bug 26048: potentially confusing "restart to update" message
      
      Within the update doorhanger, remove the misleading message that mentions
      that windows will be restored after an update is applied, and replace the
      "Restart and Restore" button label with an existing
      "Restart to update Tor Browser" string.
      
      Bug 28885: notify users that update is downloading
      
      Add a "Downloading Tor Browser update" item which appears in the
      hamburger (app) menu while the update service is downloading a MAR
      file. Before this change, the browser did not indicate to the user
      that an update was in progress, which is especially confusing in
      Tor Browser because downloads often take some time. If the user
      clicks on the new menu item, the about dialog is opened to allow
      the user to see download progress.
      
      As part of this fix, the update service was changed to always show
      update-related messages in the hamburger menu, even if the update
      was started in the foreground via the about dialog or via the
      "Check for Tor Browser Update" toolbar menu item. This change is
      consistent with the Tor Browser goal of making sure users are
      informed about the update process.
      
      Removed #28885 parts of this patch which have been uplifted to Firefox.
      
      Use a localized string from Torbutton for the app menu's
      "Downloading update" message. This is a temporary fix that can
      be removed once Tor Browser is based on Firefox 79 or newer (at
      which point the localized string will be included in the Firefox
      language packs).
      775556ba
    • Kathleen Brade's avatar
      Bug 19121: reinstate the update.xml hash check · dd488730
      Kathleen Brade authored and Georg Koppen's avatar Georg Koppen committed
      Revert most changes from Mozilla Bug 1373267 "Remove hashFunction and
      hashValue attributes from nsIUpdatePatch and code related to these
      attributes." Changes to the tests were not reverted; the tests have
      been changed significantly and we do not run automated updater tests
      for Tor Browser at this time.
      
      Also partial revert of commit f1241db6.
      
      Revert the nsUpdateService.js changes from Mozilla Bug 862173 "don't
      verify mar file hash when using mar signing to verify the mar file
      (lessens main thread I/O)."
      
      Changes to the tests were not reverted; the tests have been changed
      significantly and we do not run automated updater tests for
      Tor Browser at this time.
      
      We kept the addition to the AppConstants API in case other JS code
      references it in the future.
      dd488730
    • teor's avatar
      Bug 21724: Make Firefox and Tor Browser distinct macOS apps · 4e498a78
      teor authored and Georg Koppen's avatar Georg Koppen committed
      When macOS opens a document or selects a default browser, it sometimes
      uses the CFBundleSignature. Changing from the Firefox MOZB signature to
      a different signature TORB allows macOS to distinguish between Firefox
      and Tor Browser.
      4e498a78
    • Kathleen Brade's avatar
      Bug 11641: change TBB directory structure to be more like Firefox's · 7513952b
      Kathleen Brade authored and Georg Koppen's avatar Georg Koppen committed
      Unless the -osint command line flag is used, the browser now defaults
      to the equivalent of -no-remote.  There is a new -allow-remote flag that
      may be used to restore the original (Firefox-like) default behavior.
      7513952b
    • Kathleen Brade's avatar
      Bug 19273: Avoid JavaScript patching of the external app helper dialog. · 0c92fb7e
      Kathleen Brade authored and Georg Koppen's avatar Georg Koppen committed
      When handling an external URI or downloading a file, invoke Torbutton's
      external app blocker component (which will present a download warning
      dialog unless the user has checked the "Automatically download files
      from now on" box).
      
      For e10s compatibility, avoid using a modal dialog and instead use
      a callback interface (nsIHelperAppWarningLauncher) to allow Torbutton
      to indicate the user's desire to cancel or continue each request.
      
      Other bugs fixed:
       Bug 21766: Crash with e10s enabled while trying to download a file
       Bug 21886: Download is stalled in non-e10s mode
       Bug 22471: Downloading files via the PDF viewer download button is broken
       Bug 22472: Fix FTP downloads when external helper app dialog is shown
       Bug 22610: Avoid crashes when canceling external helper app downloads
       Bug 22618: Downloading pdf file via file:/// is stalling
      0c92fb7e
    • Georg Koppen's avatar
      Bug 18821: Disable libmdns for Android and Desktop · 750a6116
      Georg Koppen authored
      There should be no need to remove the OS X support introduced in
      https://bugzilla.mozilla.org/show_bug.cgi?id=1225726 as enabling this
      is governed by a preference (which is actually set to `false`). However,
      we remove it at build time as well (defense in depth).
      
      This is basically a backout of the relevant passages of
      https://hg.mozilla.org/mozilla-central/rev/6bfb430de85d,
      https://hg.mozilla.org/mozilla-central/rev/609b337bf7ab and
      https://hg.mozilla.org/mozilla-central/rev/8e092ec5fbbd.
      
      Fixed bug 21861 (Disable additional mDNS code to avoid proxy bypasses)
      as well.
      750a6116
    • Kathleen Brade's avatar
      Bug 18800: Remove localhost DNS lookup in nsProfileLock.cpp · e110fb92
      Kathleen Brade authored and Georg Koppen's avatar Georg Koppen committed
      Instead of using the local computer's IP address within
      symlink-based profile lock signatures, always use 127.0.0.1.
      e110fb92
    • Kathleen Brade's avatar
      Bug 16620: Clear window.name when no referrer sent · a9bf408f
      Kathleen Brade authored and Georg Koppen's avatar Georg Koppen committed
      Convert JS implementation (within Torbutton) to a C++ browser patch.
      a9bf408f
    • Mike Perry's avatar
      Bug 2176: Rebrand Firefox to TorBrowser · 388c91b8
      Mike Perry authored and Georg Koppen's avatar Georg Koppen committed
      See also Bugs #5194, #7187, #8115, #8219.
      
      This patch does some basic renaming of Firefox to TorBrowser. The rest of the
      branding is done by images and icons.
      
      Also fix bug 27905.
      
      Bug 25702: Update Tor Browser icon to follow design guidelines
      
      - Updated all of the branding in /browser/branding/official with new 'stable'
      icon series.
      - Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and
      add the source svg in the same directory
      - Copied /browser/branding/official over /browser/branding/nightly and the new
      /browser/branding/alpha directories. Replaced content with 'nightly' and
      'alpha' icon series.
      Updated VisualElements_70.png and VisualElements_150.png with updated icons in
      each branding directory (fixes #22654)
      - Updated firefox.VisualElementsManfiest.xml with updated colors in each
      branding directory
      - Updated content/identity-icons-brand.svg with Tor Browser icon (fixes #28111)
      - Added firefox.svg to each branding directory from which all the other icons
      are derived (apart from document.icns and document.ico)
      - Added default256.png and default512.png icons
      - Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed
      original icon
      - Use the Tor Browser icon within devtools/client/themes/images/.
      
      Bug 30631: Blurry Tor Browser icon on macOS app switcher
      
      It would seem the png2icns tool does not generate correct icns files and
      so on macOS the larger icons were missing resulting in blurry icons in
      the OS chrome. Regenerated the padded icons in a macOS VM using
      iconutil.
      
      Bug 28196: preparations for using torbutton tor-browser-brand.ftl
      
      A small change to Fluent FileSource class is required so that we
      can register a new source without its supported locales being
      counted as available locales for the browser.
      
      Bug 31803: Replaced about:debugging logo with flat version
      388c91b8
    • Kathleen Brade's avatar
      Bug 13252: Do not store data in the app bundle · a8c9034b
      Kathleen Brade authored and Georg Koppen's avatar Georg Koppen committed
      When --enable-tor-browser-data-outside-app-dir is enabled,
      all user data is stored in a directory named
      TorBrowser-Data which is located next to the application directory.
      
      Display an informative error message if the TorBrowser-Data
      directory cannot be created due to an "access denied" or a
      "read only volume" error.
      
      On Mac OS, add support for the --invisible command line option which
      is used by the meek-http-helper to avoid showing an icon for the
      helper browser on the dock.
      a8c9034b
    • Kathleen Brade's avatar
      Bug 14631: Improve profile access error messages. · 2c981e95
      Kathleen Brade authored and Georg Koppen's avatar Georg Koppen committed
      Instead of always reporting that the profile is locked, display specific
      messages for "access denied" and "read-only file system".
      
      To allow for localization, get profile-related error strings from Torbutton.
      Use app display name ("Tor Browser") in profile-related error alerts.
      2c981e95
    • Kathleen Brade's avatar
      Bug 9173: Change the default Firefox profile directory to be TBB-relative. · 53909e46
      Kathleen Brade authored and Georg Koppen's avatar Georg Koppen committed
      This should eliminate our need to rely on a wrapper script that
      sets /Users/arthur and launches Firefox with -profile.
      53909e46
    • Mike Perry's avatar
      Bug 13028: Prevent potential proxy bypass cases. · d7e3993b
      Mike Perry authored and Georg Koppen's avatar Georg Koppen committed
      It looks like these cases should only be invoked in the NSS command line
      tools, and not the browser, but I decided to patch them anyway because there
      literally is a maze of network function pointers being passed around, and it's
      very hard to tell if some random code might not pass in the proper proxied
      versions of the networking code here by accident.
      d7e3993b
    • Kathleen Brade's avatar
      Bug 16439: Remove screencasting code · 8270443f
      Kathleen Brade authored and Georg Koppen's avatar Georg Koppen committed
      We avoid including the screencasting code on mobile (it got ripped out
      for desktop in bug 1393582) by simply excluding the related JS modules
      from Tor Browser.
      8270443f
    • Mike Perry's avatar
      Bug 12974: Disable NTLM and Negotiate HTTP Auth · c2942bcb
      Mike Perry authored and Georg Koppen's avatar Georg Koppen committed
      This is technically an embargoed Mozilla bug, so I probably shouldn't provide
      too many details.
      
      Suffice to say that NTLM and Negotiate auth are bad for Tor users, and I doubt
      very many (or any of them) actually need it.
      
      The Mozilla bug is https://bugzilla.mozilla.org/show_bug.cgi?id=1046421
      c2942bcb
    • Mike Perry's avatar
      Bug 3547: Block all plugins. · 62292cff
      Mike Perry authored and Georg Koppen's avatar Georg Koppen committed
      We cannot use the @mozilla.org/extensions/blocklist;1 service, because we
      actually want to stop plugins from ever entering the browser's process space
      and/or executing code (for example, AV plugins that collect statistics/analyse
      urls, magical toolbars that phone home or "help" the user, skype buttons that
      ruin our day, and censorship filters). Hence we rolled our own.
      
      See https://trac.torproject.org/projects/tor/ticket/3547#comment:6 for musings
      on a better way. Until then, it is delta-darwinism for us.
      62292cff
    • Alex Catarineu's avatar
      Add TorStrings module for localization · 03bb1f56
      Alex Catarineu authored and Georg Koppen's avatar Georg Koppen committed
      03bb1f56
    • Alex Catarineu's avatar
      Bug 10760: Integrate TorButton to TorBrowser core · 736092c9
      Alex Catarineu authored and Georg Koppen's avatar Georg Koppen committed
      Because of the non-restartless nature of Torbutton, it required
      a two-stage installation process. On mobile, it was a problem,
      because it was not loading when the user opened the browser for
      the first time.
      
      Moving it to tor-browser and making it a system extension allows it
      to load when the user opens the browser for first time.
      
      Additionally, this patch also fixes Bug 27611.
      
      Bug 26321: New Circuit and New Identity menu items
      
      Bug 14392: Make about:tor behave like other initial pages.
      
      Bug 25013: Add torbutton as a tor-browser submodule
      736092c9
    • Kathleen Brade's avatar
      Bug 28044: Integrate Tor Launcher into tor-browser · f7f0cd28
      Kathleen Brade authored and Georg Koppen's avatar Georg Koppen committed
      Build and package Tor Launcher as part of the browser (similar to
      how pdfjs is handled).
      
      If a Tor Launcher extension is present in the user's profile, it is
      removed.
      f7f0cd28
    • Georg Koppen's avatar
      Bug 14970: Don't block our unsigned extensions · c1e58594
      Georg Koppen authored
      Mozilla introduced extension signing as a way to make it harder for an
      attacker to get a malicious add-on running in a user's browser. See:
      https://blog.mozilla.org/addons/2015/02/10/extension-signing-safer-experience
      and https://blog.mozilla.org/addons/2016/01/22/add-on-signing-update/
      for some background information.
      
      Since ESR45 this feature is enabled by default and we exempt EFF's
      HTTPS-Everywhere from this requirement.
      c1e58594
    • Arthur Edelstein's avatar
      Bug 12620: TorBrowser regression tests · 9a5eb16f
      Arthur Edelstein authored and Georg Koppen's avatar Georg Koppen committed
      Regression tests for Bug #2950: Make Permissions Manager memory-only
      
      Regression tests for TB4: Tor Browser's Firefox preference overrides.
      
      Note: many more functional tests could be made here
      
      Regression tests for #2874: Block Components.interfaces from content
      
      Bug 18923: Add a script to run all Tor Browser specific tests
      
      Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt.
      9a5eb16f
    • Mike Perry's avatar
      TB4: Tor Browser's Firefox preference overrides. · 54ec3380
      Mike Perry authored and Georg Koppen's avatar Georg Koppen committed
      This hack directly includes our preference changes in omni.ja.
      
      Bug 18292: Staged updates fail on Windows
      
      Temporarily disable staged updates on Windows.
      
      Bug 18297: Use separate Noto JP,KR,SC,TC fonts
      
      Bug 23404: Add Noto Sans Buginese to the macOS whitelist
      
      Bug 23745: Set dom.indexedDB.enabled = true
      
      Bug 13575: Disable randomised Firefox HTTP cache decay user tests.
      (Fernando Fernandez Mancera <ffmancera@riseup.net>)
      
      Bug 17252: Enable session identifiers with FPI
      
      Session tickets and session identifiers were isolated
      by OriginAttributes, so we can re-enable them by
      allowing the default value (true) of
      "security.ssl.disable_session_identifiers".
      
      The pref "security.enable_tls_session_tickets" is obsolete
      (removed in https://bugzilla.mozilla.org/917049)
      
      Bug 14952: Enable http/2 and AltSvc
      
      In Firefox, SPDY/HTTP2 now uses Origin Attributes for
      isolation of connections, push streams, origin frames, etc.
      That means we get first-party isolation provided
      "privacy.firstparty.isolate" is true. So in this patch, we
      stop overriding "network.http.spdy.enabled" and
      "network.http.spdy.enabled.http2".
      
      Alternate Services also use Origin Attributes for isolation.
      So we stop overriding
      "network.http.altsvc.enabled" and "network.http.altsvc.oe"
      as well.
      
      (All 4 of the abovementioned "network.http.*" prefs adopt
      Firefox 60ESR's default value of true.)
      
      However, we want to disable HTTP/2 push for now, so we
      set "network.http.spdy.allow-push" to false.
      
      "network.http.spdy.enabled.http2draft" was removed in Bug 1132357.
      "network.http.sped.enabled.v2" was removed in Bug 912550.
      "network.http.sped.enabled.v3" was removed in Bug 1097944.
      "network.http.sped.enabled.v3-1" was removed in Bug 1248197.
      
      Bug 26114: addons.mozilla.org is not special
      * Don't expose navigator.mozAddonManager on any site
      * Don't block NoScript from modifying addons.mozilla.org or other sites
      
      Enable ReaderView mode again (#27281).
      
      Bug 29916: Make sure enterprise policies are disabled
      
      Bug 2874: Block Components.interfaces from content
      
      Bug 26146: Spoof HTTP User-Agent header for desktop platforms
      
      In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent
      header and to JavaScript code via navigator.userAgent. To avoid
      leaking the OS inside each HTTP request (which many web servers
      log), always use the Windows 7 OS value in the desktop User-Agent
      header. We continue to allow access to the actual OS via JavaScript,
      since doing so improves compatibility with web applications such
      as GitHub and Google Docs.
      
      Bug 12885: Windows Jump Lists fail for Tor Browser
      
      Jumplist entries are stored in a binary file in:
        %APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\
      and has a name in the form
        [a-f0-9]+.customDestinations-ms
      
      The hex at the front is unique per app, and is ultimately derived from
      something called the 'App User Model ID' (AUMID) via some unknown
      hashing method. The AUMID is provided as a key when programmatically
      creating, updating, and deleting a jumplist. The default behaviour in
      firefox is for the installer to define an AUMID for an app, and save it
      in the registry so that the jumplist data can be removed by the
      uninstaller.
      
      However, the Tor Browser does not set this (or any other) regkey during
      installation, so this codepath fails and the app's AUMID is left
      undefined. As a result the app's AUMID ends up being defined by
      windows, but unknowable by Tor Browser. This unknown AUMID is used to
      create and modify the jumplist, but the delete API requires that we
      provide the app's AUMID explicitly. Since we don't know what the AUMID
      is (since the expected regkey where it is normally stored does not
      exist) jumplist deletion will fail and we will leave behind a mostly
      empty customDestinations-ms file. The name of the file is derived from
      the binary path, so an enterprising person could reverse engineer how
      that hex name is calculated, and generate the name for Tor Browser's
      default Desktop installation path to determine whether a person had
      used Tor Browser in the past.
      
      The 'taskbar.grouping.useprofile' option that is enabled by this patch
      works around this AUMID problem by having firefox.exe create it's own
      AUMID based on the profile path (rather than looking for a regkey). This
      way, if a user goes in and enables and disables jumplist entries, the
      backing store is properly deleted.
      
      Unfortunately, all windows users currently have this file lurking in
      the above mentioned directory and this patch will not remove it since it
      was created with an unknown AUMID. However, another patch could be
      written which goes to that directory and deletes any item containing the
      'Tor Browser' string.  See bug 28996.
      
      Bug 31396: Disable indexedDB WebExtension storage backend.
      
      Bug 30845: Make sure default themes and other internal extensions are enabled
      
      Bug 28896: Enable extensions in private browsing by default
      
      Bug 31065: Explicitly allow proxying localhost
      
      Bug 31598: Enable letterboxing
      
      Disable Presentation API everywhere
      
      Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer
      security levels.
      
      Bug 32321: Disable Mozilla's MitM pings
      
      Bug 19890: Disable installation of system addons
      
      By setting the URL to "" we make sure that already installed system
      addons get deleted as well.
      
      Bug 22548: Firefox downgrades VP9 videos to VP8.
      
      On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor
      Browser 7.0 all youtube videos are degraded to VP8.
      
      This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0.
      All clients will get better experience and lower traffic, beause TBB doesn't
      use "Use hardware acceleration when available".
      
      Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs
      
      Bug 16441: Suppress "Reset Tor Browser" prompt.
      
      Bug 29120: Use the in-memory media cache and increase its maximum size.
      
      Bug 33697: use old search config based on list.json
      
      Bug 33855: Ensure that site-specific browser mode is disabled.
      
      Bug 30682: Disable Intermediate CA Preloading.
      
      Bug 40061: Omit the Windows default browser agent from the build
      54ec3380
    • Mike Perry's avatar
      TB3: Tor Browser's official .mozconfigs. · c533df1e
      Mike Perry authored and Georg Koppen's avatar Georg Koppen committed
      Also:
      Bug #9829.1: new .mozconfig file for the new cross-compiler and ESR24
      Changes needed to build Mac in 64bit
      Bug 10715: Enable Webgl for mingw-w64 again.
      Disable ICU when cross-compiling; clean-up.
      Bug 15773: Enable ICU on OS X
      Bug 15990: Don't build the sandbox with mingw-w64
      Bug 12761: Switch to ESR 38 for OS X
      Updating .mozconfig-asan
      Bug 12516: Compile hardenend Tor Browser with -fwrapv
      Bug 18331: Switch to Mozilla's toolchain for building Tor Browser for OS X
      Bug 17858: Cannot create incremental MARs for hardened builds.
      Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff
      (which is part of mar-tools and is not distributed to end-users) with
      ASan.
      Bug 13419: Add back ICU for Windows
      Bug 21239: Use GTK2 for ESR52 Linux builds
      Bug 23025: Add hardening flags for macOS
      Bug 24478: Enable debug assertions and tests in our ASan builds
      --enable-proxy-bypass-protection
      Bug 27597: ASan build option in tor-browser-build is broken
      
      Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds
      
      This fixes a problem where some preferences had the wrong default value.
      Also see bug 27472 where we made a similar fix for Android.
      
      Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING
      
      Bug 31450: Set proper BINDGEN_CFLAGS for ASan builds
      
      Add an --enable-tor-browser-data-outside-app-dir configure option
      
      Add --with-tor-browser-version configure option
      
      Bug 21849: Don't allow SSL key logging.
      
      Bug 31457: disable per-installation profiles
      
      The dedicated profiles (per-installation) feature does not interact
      well with our bundled profiles on Linux and Windows, and it also causes
      multiple profiles to be created on macOS under TorBrowser-Data.
      
      Bug 31935: Disable profile downgrade protection.
      
      Since Tor Browser does not support more than one profile, disable
      the prompt and associated code that offers to create one when a
      version downgrade situation is detected.
      
      Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT
      
      Bug 25741 - TBA: Disable features at compile-time
      
      MOZ_NATIVE_DEVICES for casting and the media player
      MOZ_TELEMETRY_REPORTING for telemetry
      MOZ_DATA_REPORTING for all data reporting preferences (crashreport, telemetry, geo)
      
      Bug 25741 - TBA: Add default configure options in dedicated file
      
      Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION
      
      Bug 29859: Disable HLS support for now
      
      Add --disable-tor-launcher build option
      
      Add --enable-tor-browser-update build option
      
      Bug 33734: Set MOZ_NORMANDY to False
      
      Bug 33851: Omit Parental Controls.
      
      Bug 40061: Omit the Windows default browser agent from the build
      c533df1e
    • Matthew Finkel's avatar
    • Mark Smith's avatar
      Bug 1642754 - Update prompts should not depend on how update was initiated r=bytesized · 90bbfbed
      Mark Smith authored and Georg Koppen's avatar Georg Koppen committed
      Show update badge and doorhanger when entering the "pending"
      state for foreground updates.
      
      Differential Revision: https://phabricator.services.mozilla.com/D79903
      90bbfbed
    • Mark Smith's avatar
      Bug 1642404 - add an option to show that an update is being downloaded... · 5dd78f91
      Mark Smith authored and Georg Koppen's avatar Georg Koppen committed
      Bug 1642404 - add an option to show that an update is being downloaded r=bytesized,fluent-reviewers,flod
      
      Add support for a hidden preference named app.update.notifyDuringDownload
      that, when set to true, causes a "Downloading update" message to appear
      in the app menu during a MAR download. Clicking the message opens the
      about box so the user can see detailed progress information.
      
      Differential Revision: https://phabricator.services.mozilla.com/D77688
      5dd78f91
  2. 17 Aug, 2020 1 commit