Closes ticket 32704.

"ours" to avoid version bump.

"ours" to avoid version bump.

"ours" to avoid version bump.

"ours" to avoid version bump.

teor authored Dec 03, 2019 and Nick Mathewson committed Dec 04, 2019

All of these files contain "*.h", except for:
* src/app/config/.may_include
* src/test/.may_include
which also contain "*.inc".

This change prevents includes of "*.c" files, and other
unusually named files.

Part of 32609.

teor authored Dec 03, 2019 and Nick Mathewson committed Dec 04, 2019

Extra testing after 32613.

teor authored Nov 16, 2019 and Nick Mathewson committed Dec 04, 2019

Part of 32522.

teor authored Nov 16, 2019 and Nick Mathewson committed Dec 04, 2019

Add a check-practracker-unit-test target, and run it as part of
"make check".

Add the practracker unit tests to scripts/git/pre-commit.git-hook.

Part of 32609.

Found by Stem regression tests. Reported by atagar.

Fixes #32664

Signed-off-by: David Goulet <dgoulet@torproject.org>

George Kadianakis authored Nov 25, 2019 and David Goulet committed Dec 03, 2019

Now we have a function that reads a file and returns a credential. We need that
for the REMOVE control port command.

George Kadianakis authored Nov 25, 2019 and David Goulet committed Dec 03, 2019

- Remove key_dir which is useless.
- Kill an indentation layer.

We want to make it cleaner and slimmer so that we can reuse parts of it in the
REMOVE command for removing the right client auth file.

George Kadianakis authored Nov 25, 2019 and David Goulet committed Dec 03, 2019

Because the function that parses client auth credentials saved on
disk (parse_auth_file_content()) is not future compatible, there is no way to
add support for storing the nickname on the disk. Hence, nicknames cannot
persist after Tor restart making them pretty much useless.

In the future we can introduce nicknames by adding a new file format for client
auth credentials, but this was not deemed worth doing at this stage.

George Kadianakis authored Nov 25, 2019 and David Goulet committed Dec 03, 2019

Remove Permanent flag from old tests, and make a new test that does all the
permanent things.

George Kadianakis authored Nov 25, 2019 and David Goulet committed Dec 03, 2019

- See hs_client_register_auth_credentials() for the entry point.
- Also set the permanent flag for credentials we read from the filesystem.
- Also add some missing documentation.