Skip to content
  • George Kadianakis's avatar
    Fix an enum comparison that was blowing up jenkins. · baee2fed
    George Kadianakis authored
    The warning was:
        11:23:10 ../tor/src/feature/hs/hs_service.c: In function 'log_cant_upload_desc':
        11:23:10 ../tor/src/feature/hs/hs_service.c:3118:3: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
    See #34254 for more info.
    
    I guess this means that gcc assigned an unsigned type to the
    `log_desc_upload_reason_t` enum and it warned if we compared it against 0...
    
    For now I think it's simpler to remove that check instead of turning the enum
    to a signed type, or trying to hack it some other way.
    
    From what it seems, enum is up to the compiler on whether it's signed/unsigned:
         https://stackoverflow.com/questions/159034/are-c-enums-signed-or-unsigned
    baee2fed