Commit 609c1e88 authored by Nick Mathewson's avatar Nick Mathewson 🥔
Browse files

Start writing a how to review doc

parent 7dbcdfab

doc/HACKING/CodingStandards.txt

+3 −0
Original line number Diff line number Diff line
@@ -141,6 +141,9 @@ sure that we worked on MSVC6. 
We don't use strcat or strcpy or sprintf of any of those notoriously broken

old C functions.  Use strlcat, strlcpy, or tor_snprintf/tor_asprintf instead.



We don't call memcmp() directly.  Use fast_memeq(), fast_memneq(),

tor_memeq(), or tor_memneq() for most purposes.



Functions not to write

~~~~~~~~~~~~~~~~~~~~~~

doc/include.am

+1 −0
Original line number Diff line number Diff line
@@ -43,6 +43,7 @@ EXTRA_DIST+= doc/asciidoc-helper.sh \ 
	     doc/HACKING/CodingStandards.txt			\

	     doc/HACKING/GettingStarted.txt			\

	     doc/HACKING/HelpfulTools.txt			\

	     doc/HACKING/HowToReview.txt 			\

	     doc/HACKING/ReleasingTor.txt                       \

	     doc/HACKING/WritingTests.txt