Commit 72e30f26 authored by Nick Mathewson's avatar Nick Mathewson 🦀
Browse files

Fix a pair of errors in bug23512

parent 6af35217

src/or/rephist.c

+2 −3
Original line number Diff line number Diff line
@@ -1211,7 +1211,7 @@ rep_hist_load_mtbf_data(time_t now) 
/** Structure to track bandwidth use, and remember the maxima for a given

 * time period.

 */

typedef struct bw_array_t {

struct bw_array_t {

  /** Observation array: Total number of bytes transferred in each of the last

   * NUM_SECS_ROLLING_MEASURE seconds. This is used as a circular array. */

  uint64_t obs[NUM_SECS_ROLLING_MEASURE];
@@ -1238,7 +1238,7 @@ typedef struct bw_array_t { 
  /** Circular array of the total bandwidth usage for the last NUM_TOTALS

   * periods */

  uint64_t totals[NUM_TOTALS];

} bw_array_t;

};



/** Shift the current period of b forward by one. */

STATIC void
@@ -3297,4 +3297,3 @@ rep_hist_free_all(void) 
  tor_assert_nonfatal(rephist_total_alloc == 0);

  tor_assert_nonfatal_once(rephist_total_num == 0);

}

src/test/test_relay.c

+2 −3
Original line number Diff line number Diff line
@@ -111,7 +111,7 @@ test_relay_close_circuit(void *arg) 
  tt_int_op(new_count, OP_EQ, old_count + 1);



  /* Ensure our write totals are 0 */

  tt_int_op(find_largest_max(write_array), OP_EQ, 0);

  tt_u64_op(find_largest_max(write_array), OP_EQ, 0);



  /* Mark the circuit for close */

  circuit_mark_for_close(TO_CIRCUIT(orcirc), 0);
@@ -120,7 +120,7 @@ test_relay_close_circuit(void *arg) 
  advance_obs(write_array);

  commit_max(write_array);

  /* Check for two cells plus overhead */

  tt_int_op(find_largest_max(write_array), OP_EQ,

  tt_u64_op(find_largest_max(write_array), OP_EQ,

                             2*(get_cell_network_size(nchan->wide_circ_ids)

                                +TLS_PER_CELL_OVERHEAD));
@@ -233,4 +233,3 @@ struct testcase_t relay_tests[] = { 
    TT_FORK, NULL, NULL },

  END_OF_TESTCASES

};