Commit 899d2b89 authored by George Kadianakis's avatar George Kadianakis Committed by David Goulet
Browse files

prop250: Don't use {0} to init static struct -- causes warning on clang. 

See ticket #19132 for the clang/llvm warning.

Since voting_schedule is a global static struct, it will be initialized
to zero even without explicitly initializing it with {0}.

This is what the C spec says:

	If an object that has automatic storage duration is not initialized
	explicitly, its value is indeterminate. If an object that has static
	storage duration is not initialized explicitly, then:

	— if it has pointer type, it is initialized to a null pointer;
	— if it has arithmetic type, it is initialized to (positive or unsigned) zero;
	— if it is an aggregate, every member is initialized (recursively) according to these rules;
	— if it is a union, the first named member is initialized (recursively) according to these rules.
parent ebbff317

src/or/dirvote.c

+1 −1
Original line number Diff line number Diff line
@@ -2545,7 +2545,7 @@ get_next_valid_after_time(time_t now) 
  return next_valid_after_time;

}



static voting_schedule_t voting_schedule = {0};

static voting_schedule_t voting_schedule;



/** Set voting_schedule to hold the timing for the next vote we should be

 * doing. */