Existing cached directory information can cause misleadingly high
bootstrap percentages.  To improve user experience, defer reporting of
directory information progress until at least one connection has
succeeded to a relay or bridge.

Closes ticket 27169.

Track bootstrap phase (enumerated by bootstrap_status_t) independently
from the bootstrap progress (which can represent intermediate
progress).  This allows control_event_bootstrap_problem() to avoid
doing a linear search through the bootstrap progress space to find the
current bootstrap phase.

Eliminate a few conditional expressions in
control_event_bootstrap_core() by overwriting the status parameter.

Move the mostly-invariant part of control_event_boostrap() into a
helper control_event_bootstrap_core().  The helper doesn't modify any
state beyond doing logging and control port notifications.

Simplify control_event_bootstrap() by making it return void again.  It
is currently a fairly complicated function, and it's made more
complicated by returning an int to signal whether it logged at NOTICE
or INFO.

The callers conditionally log messages at level NOTICE based on this
return value.  Change the callers to unconditionally log their verbose
human-readable messages at level INFO to keep NOTICE logs less
cluttered.

This partially reverts the changes of #14950.

"ours" to avoid version bump.

"ours" to avoid version bump.

"ours" to avoid version bump.

"ours" to avoid version bump.

This is an attempt to work around what I think may be a bug in
OSS-Fuzz, which thinks that uninitialized data might be passed to
the curve25519 functions.

(a relay operator hit this on #tor-relays and couldn't make sense
of it. i couldn't either until i went to go read the code.)

"ours" to avoid bump.

"ours" to avoid bump

"ours" to avoid bump

George Kadianakis authored Sep 06, 2018 and David Goulet committed Sep 07, 2018

Also update some client auth test vectors that broke...

Return a newly allocated fake client authorization object instead of taking
the object as a parameter.

Signed-off-by: David Goulet <dgoulet@torproject.org>

haxxpop authored Sep 03, 2018 and David Goulet committed Sep 07, 2018

In function get_fname_suffix, previously it uses /, but in fact it
should use PATH_SEPARATOR.

Part of #20700.

Signed-off-by: David Goulet <dgoulet@torproject.org>

haxxpop authored Aug 19, 2018 and David Goulet committed Sep 07, 2018

Signed-off-by: David Goulet <dgoulet@torproject.org>

haxxpop authored Aug 19, 2018 and David Goulet committed Sep 07, 2018

Signed-off-by: David Goulet <dgoulet@torproject.org>

haxxpop authored May 22, 2018 and David Goulet committed Sep 07, 2018

Signed-off-by: David Goulet <dgoulet@torproject.org>

haxxpop authored May 22, 2018 and David Goulet committed Sep 07, 2018

Signed-off-by: David Goulet <dgoulet@torproject.org>

haxxpop authored May 16, 2018 and David Goulet committed Sep 07, 2018

Signed-off-by: David Goulet <dgoulet@torproject.org>

haxxpop authored May 10, 2018 and David Goulet committed Sep 07, 2018

When reloading tor, check if our the configured client authorization have
changed from what we previously had. If so, republish the updated descriptor.

Signed-off-by: David Goulet <dgoulet@torproject.org>

haxxpop authored May 10, 2018 and David Goulet committed Sep 07, 2018

Series of functions that we now need in hs_service.c.

Signed-off-by: David Goulet <dgoulet@torproject.org>

haxxpop authored Apr 22, 2018 and David Goulet committed Sep 07, 2018

Previously, the validation by decoding a created descriptor was disabled
because the interface had to be entirely changed and not implemented at the
time.

This commit re-enabled it because it is now implemented.

Signed-off-by: David Goulet <dgoulet@torproject.org>

haxxpop authored Apr 22, 2018 and David Goulet committed Sep 07, 2018

Signed-off-by: David Goulet <dgoulet@torproject.org>