GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  1. 06 Jul, 2020 2 commits
    • Alexander Færøy's avatar
      Fix out-of-bound memory read in `tor_tls_cert_matches_key()` for NSS. · b46984e9
      Alexander Færøy authored
      This patch fixes an out-of-bound memory read in
      `tor_tls_cert_matches_key()` when Tor is compiled to use Mozilla's NSS
      instead of OpenSSL.
      
      The NSS library stores some length fields in bits instead of bytes, but
      the comparison function found in `SECITEM_ItemsAreEqual()` needs the
      length to be encoded in bytes. This means that for a 140-byte,
      DER-encoded, SubjectPublicKeyInfo struct (with a 1024-bit RSA public key
      in it), we would ask `SECITEM_ItemsAreEqual()` to compare the first 1120
      bytes instead of 140 (140bytes * 8bits = 1120bits).
      
      This patch fixes the issue by converting from bits to bytes before
      calling `SECITEM_ItemsAreEqual()` and convert the `len`-fields back to
      bits before we leave the function.
      
      This patch is part of the fix for TROVE-2020-001.
      
      See: https://bugs.torproject.org/33119
      b46984e9
    • Alexander Færøy's avatar
      Run `tor_tls_cert_matches_key()` Test Suite with both OpenSSL and NSS. · 33e1c2e6
      Alexander Færøy authored
      This patch lifts the `tor_tls_cert_matches_key()` tests out of the
      OpenSSL specific TLS test suite and moves it into the generic TLS test
      suite that is executed for both OpenSSL and NSS.
      
      This patch is largely a code movement, but we had to rewrite parts of
      the test to avoid using OpenSSL specific data-types (such as `X509 *`)
      and replace it with the generic Tor abstraction type
      (`tor_x509_cert_impl_t *`).
      
      This patch is part of the fix for TROVE-2020-001.
      
      See: https://bugs.torproject.org/33119
      33e1c2e6
  2. 30 Jun, 2020 5 commits
  3. 29 Jun, 2020 1 commit
  4. 12 Jun, 2020 1 commit
  5. 05 Jun, 2020 1 commit
  6. 03 Jun, 2020 1 commit
  7. 30 May, 2020 1 commit
    • Roger Dingledine's avatar
      Preemptive circs should work with UseEntryGuards 0 · 39f2411b
      Roger Dingledine authored
      Resume being willing to use preemptively-built circuits when
      UseEntryGuards is set to 0. We accidentally disabled this feature with
      that config setting (in our fix for #24469), leading to slower load times.
      
      Fixes bug 34303; bugfix on 0.3.3.2-alpha.
      39f2411b
  8. 15 May, 2020 1 commit
  9. 14 May, 2020 1 commit
  10. 06 May, 2020 9 commits
  11. 09 Apr, 2020 1 commit
  12. 20 Mar, 2020 1 commit
    • teor's avatar
      Appveyor: Copy required DLLs to test and app · 38e07b88
      teor authored
      Copy required DLLs to test and app, before running tor's tests.
      
      This ensures that tor.exe and test*.exe use the correct version of each
      DLL. This fix is not required, but we hope it will avoid DLL search
      issues in future.
      
      Closes bug 33673; bugfix on 0.3.4.2-alpha.
      38e07b88
  13. 19 Mar, 2020 2 commits
  14. 18 Mar, 2020 2 commits
  15. 17 Mar, 2020 6 commits
  16. 16 Mar, 2020 1 commit
  17. 14 Mar, 2020 3 commits
  18. 13 Mar, 2020 1 commit