1. 10 Jun, 2019 1 commit
    • teor's avatar
      Travis: Skip test_rebind on macOS builds · be0a4be2
      teor authored
      Skip test_rebind when the TOR_SKIP_TEST_REBIND environmental variable
      is set.
      
      Skip test_rebind on macOS in Travis builds, because it is unreliable
      on macOS on Travis.
      
      Fixes bug 30713; bugfix on 0.3.5.1-alpha.
      be0a4be2
  2. 17 May, 2019 1 commit
  3. 10 May, 2019 1 commit
    • Nick Mathewson's avatar
      Don't pass a NULL into a %s when logging client auth file load failure · ff558403
      Nick Mathewson authored
      Fortunately, in 0.3.5.1-alpha we improved logging for various
      failure cases involved with onion service client auth.
      
      Unfortunately, for this one, we freed the file right before logging
      its name.
      
      Fortunately, tor_free() sets its pointer to NULL, so we didn't have
      a use-after-free bug.
      
      Unfortunately, passing NULL to %s is not defined.
      
      Fortunately, GCC 9.1.1 caught the issue!
      
      Unfortunately, nobody has actually tried building Tor with GCC 9.1.1
      before. Or if they had, they didn't report the warning.
      
      Fixes bug 30475; bugfix on 0.3.5.1-alpha.
      ff558403
  4. 12 Apr, 2019 1 commit
  5. 08 Apr, 2019 1 commit
    • Nick Mathewson's avatar
      Detect and suppress an additional gmtime() warning in test_util.c · a63bd877
      Nick Mathewson authored
      Fixes bug 29922; bugfix on 0.2.9.3-alpha when we tried to capture
      all these warnings.  No need to backport any farther than 0.3.5,
      though -- these warnings don't cause test failures before then.
      
      This one was tricky to find because apparently it only happened on
      _some_ windows builds.
      a63bd877
  6. 04 Apr, 2019 2 commits
    • Nick Mathewson's avatar
      Do not cache bogus results from classifying client ciphers · 1710f4bb
      Nick Mathewson authored
      When classifying a client's selection of TLS ciphers, if the client
      ciphers are not yet available, do not cache the result. Previously,
      we had cached the unavailability of the cipher list and never looked
      again, which in turn led us to assume that the client only supported
      the ancient V1 link protocol.  This, in turn, was causing Stem
      integration tests to stall in some cases.  Fixes bug 30021; bugfix
      on 0.2.4.8-alpha.
      1710f4bb
    • teor's avatar
      Travis: Terminate test-stem if it takes more than 9.5 minutes to run · 3fa42d59
      teor authored
      (Travis terminates the job after 10 minutes of no output.)
      
      Diagnostic for 29437.
      
      Fixes bug 30011; bugfix on 0.3.5.4-alpha.
      3fa42d59
  7. 03 Apr, 2019 1 commit
  8. 01 Apr, 2019 2 commits
  9. 22 Mar, 2019 1 commit
  10. 21 Mar, 2019 1 commit
    • juga's avatar
      bwauth: Ignore bandwidth file lines with "vote=0" · 4ab2e9a5
      juga authored and teor's avatar teor committed
      so that the relays that would be "excluded" from the bandwidth
      file because of something failed can be included to diagnose what
      failed, without still including these relays in the bandwidth
      authorities vote.
      
      Closes #29806.
      4ab2e9a5
  11. 20 Mar, 2019 1 commit
  12. 15 Mar, 2019 1 commit
  13. 14 Mar, 2019 2 commits
    • Roger Dingledine's avatar
      relays shouldn't close idle rend circuits · a3bc950e
      Roger Dingledine authored
      Allow connections to single onion services to remain idle without being
      disconnected.
      
      Relays acting as rendezvous points for single onion services were
      mistakenly closing idle established rendezvous circuits after 60 seconds,
      thinking that they are unused directory-fetching circuits that had served
      their purpose.
      
      Fixes bug 29665; bugfix on 0.2.1.26.
      a3bc950e
    • Roger Dingledine's avatar
      relays shouldn't close idle rend circuits · add0f89c
      Roger Dingledine authored
      Allow connections to single onion services to remain idle without being
      disconnected.
      
      Relays acting as rendezvous points for single onion services were
      mistakenly closing idle established rendezvous circuits after 60 seconds,
      thinking that they are unused directory-fetching circuits that had served
      their purpose.
      
      Fixes bug 29665; bugfix on 0.2.1.26.
      add0f89c
  14. 09 Mar, 2019 1 commit
  15. 08 Mar, 2019 1 commit
    • David Goulet's avatar
      hs-v2: Copy needed information between service on prunning · b4e44a37
      David Goulet authored
      
      
      Turns out that when reloading a tor configured with hidden service(s), we
      weren't copying all the needed information between the old service object to
      the new one.
      
      For instance, the desc_is_dirty timestamp wasn't which could lead to the
      service uploading its descriptor much later than it would need to.
      
      The replaycache wasn't also moved over and some intro point information as
      well.
      
      Fixes #23790
      Signed-off-by: David Goulet's avatarDavid Goulet <dgoulet@torproject.org>
      b4e44a37
  16. 06 Mar, 2019 1 commit
  17. 01 Mar, 2019 2 commits
  18. 27 Feb, 2019 2 commits
  19. 25 Feb, 2019 2 commits
  20. 21 Feb, 2019 1 commit
    • David Goulet's avatar
      kist: Don't write above the highwater outbuf mark · be84ed1a
      David Goulet authored and Nick Mathewson's avatar Nick Mathewson committed
      
      
      KIST works by computing how much should be allowed to write to the kernel for
      a given socket, and then it writes that amount to the outbuf.
      
      The problem is that it could be possible that the outbuf already has lots of
      data in it from a previous scheduling round (because the kernel is full/busy
      and Tor was not able to flush the outbuf yet). KIST ignores that the outbuf
      has been filling (is above its "highwater") and writes more anyway. The end
      result is that the outbuf length would exceed INT_MAX, hence causing an
      assertion error and a corresponding "Bug()" message to get printed to the
      logs.
      
      This commit makes it for KIST to take into account the outbuf length when
      computing the available space.
      
      Bug found and patch by Rob Jansen.
      
      Closes #29168. TROVE-2019-001.
      Signed-off-by: David Goulet's avatarDavid Goulet <dgoulet@torproject.org>
      be84ed1a
  21. 19 Feb, 2019 2 commits
  22. 12 Feb, 2019 1 commit
  23. 08 Feb, 2019 3 commits
  24. 01 Feb, 2019 1 commit
  25. 26 Jan, 2019 1 commit
  26. 23 Jan, 2019 4 commits
  27. 22 Jan, 2019 1 commit
  28. 16 Jan, 2019 1 commit