1. 06 May, 2020 1 commit
    • Nick Mathewson's avatar
      Use __attribute__((fallthrough)) rather than magic GCC comments. · cc397449
      Nick Mathewson authored
      GCC added an implicit-fallthrough warning a while back, where it
      would complain if you had a nontrivial "case:" block that didn't end
      with break, return, or something like that.  Clang recently added
      the same thing.
      
      GCC, however, would let you annotate a fall-through as intended by
      any of various magic "/* fall through */" comments.  Clang, however,
      only seems to like "__attribute__((fallthrough))".  Fortunately, GCC
      accepts that too.
      
      A previous commit in this branch defined a FALLTHROUGH macro to do
      the right thing if GNUC is defined; here we replace all of our "fall
      through" comments with uses of that macro.
      
      This is an automated commit, made with the following perl one-liner:
      
        #!/usr/bin/perl -i -p
        s#/\* *falls? ?thr.*?\*/#FALLTHROUGH;#i;
      cc397449
  2. 15 Jun, 2019 1 commit
  3. 16 Jan, 2019 1 commit
  4. 27 Sep, 2018 1 commit
    • Nick Mathewson's avatar
      Fix a memory leak in --dump-config · 8812f562
      Nick Mathewson authored
      When freeing a configuration object from confparse.c in
      dump_config(), we need to call the appropriate higher-level free
      function (like or_options_free()) and not just config_free().
      
      This only happens with options (since they're the one where
      options_validate allocates extra stuff) and only when running
      --dump-config with something other than minimal (since
      OPTIONS_DUMP_MINIMAL doesn't hit this code).
      
      Fixes bug 27893; bugfix on 0.3.2.1-alpha.
      8812f562
  5. 01 Aug, 2018 1 commit
  6. 07 Jul, 2018 1 commit
  7. 05 Jul, 2018 2 commits
    • Nick Mathewson's avatar
      Fix every include path changed in the previous commit (automated) · ef486e3c
      Nick Mathewson authored
      I am very glad to have written this script.
      ef486e3c
    • Nick Mathewson's avatar
      Move literally everything out of src/or · 63b4ea22
      Nick Mathewson authored
      This commit won't build yet -- it just puts everything in a slightly
      more logical place.
      
      The reasoning here is that "src/core" will hold the stuff that every (or
      nearly every) tor instance will need in order to do onion routing.
      Other features (including some necessary ones) will live in
      "src/feature".  The "src/app" directory will hold the stuff needed
      to have Tor be an application you can actually run.
      
      This commit DOES NOT refactor the former contents of src/or into a
      logical set of acyclic libraries, or change any code at all.  That
      will have to come in the future.
      
      We will continue to move things around and split them in the future,
      but I hope this lays a reasonable groundwork for doing so.
      63b4ea22
  8. 03 Jul, 2018 3 commits
  9. 01 Jul, 2018 1 commit
  10. 22 Jun, 2018 1 commit
  11. 20 Jun, 2018 2 commits
  12. 22 Apr, 2018 1 commit
    • Nick Mathewson's avatar
      Change the type of "download schedule" from smartlist to int. · 2d7b5c6f
      Nick Mathewson authored
      This is done as follows:
        * Only one function (find_dl_schedule()) actually returned a
          smartlist. Now it returns an int.
      
        * The CSV_INTERVAL type has been altered to ignore everything
          after the first comma, and to store the value before the first
          comma in an int.
      2d7b5c6f
  13. 08 Dec, 2017 1 commit
  14. 02 May, 2017 1 commit
    • Taylor Yu's avatar
      Delete useless checks in confparse.c · 5494087e
      Taylor Yu authored
      config_parse_interval() and config_parse_msec_interval() were checking
      whether the variable "ok" (a pointer to an int) was null, rather than
      derefencing it.  Both functions are static, and all existing callers
      pass a valid pointer to those static functions.  The callers do check
      the variables (also confusingly named "ok") whose addresses they pass
      as the "ok" arguments, so even if the pointer check were corrected to
      be a dereference, it would be redundant.
      
      Fixes #22103.
      5494087e
  15. 04 Apr, 2017 1 commit
  16. 15 Mar, 2017 1 commit
  17. 08 Mar, 2017 1 commit
  18. 30 Jan, 2017 1 commit
    • Nick Mathewson's avatar
      Make "GETCONF SocksPort" work again · 4d839992
      Nick Mathewson authored
      I broke "GETCONF *Port" in 20956, when I made SocksPort a
      subordinate option of the virtual option SocksPortLines, so that I
      could make SocksPort and __SocksPort provide qthe same
      functionality.  The problem was that you can't pass a subordinate
      option to GETCONF.
      
      So, this patch fixes that by letting you fetch subordinate options.
      
      It won't always be meaningful to consider these options
      out-of-context, but that can be the controller-user's
      responsibility to check.
      
      Closes ticket 21300.
      4d839992
  19. 18 Jan, 2017 1 commit
  20. 10 Nov, 2016 1 commit
  21. 24 Oct, 2016 1 commit
  22. 20 Aug, 2016 1 commit
  23. 03 Aug, 2016 3 commits
  24. 11 Jun, 2016 1 commit
  25. 27 Feb, 2016 2 commits
  26. 02 Jan, 2015 1 commit
  27. 28 Oct, 2014 1 commit
  28. 09 Oct, 2013 1 commit
  29. 13 Sep, 2013 2 commits
  30. 26 Jul, 2013 1 commit
  31. 24 May, 2013 1 commit
  32. 16 May, 2013 1 commit