GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Revise fix for bug 32178 (spaces at end of log msg).

The loop in the earlier patch would invoke undefined behavior in two
ways: First, it would check whether it was looking at a space before
it checked whether the pointer was in-range.  Second, it would let a
pointer reach a position _before_ the start of a string, which is
not allowed.

I've removed the assertion about empty messages: empty messages can
be their own warning IMO.

I've also added tests for this formatting code, to make sure it
actually works.
9 jobs for ticket32178_redux in 50 minutes and 20 seconds (queued for 2 minutes and 6 seconds)
latest
Status Job ID Name Coverage
  Test
passed #4511
debian-disable-dirauth

00:06:05

passed #4512
debian-disable-relay

00:12:30

passed #4507
debian-distcheck

00:07:19

passed #4508
debian-docs

00:04:23

passed #4506
debian-hardened

00:20:48

passed #4509
debian-integration

00:13:27

passed #4505
debian-minimal

00:06:05

passed #4513
debian-nss

00:11:16

passed #4510
debian-tracing

00:13:34