GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Reject obsolete router/extrainfo descs more quietly.

Thanks to proposal 315 / ticket #30132, more fields are now
required in these documents.  But ancient Tors that try to upload
obsolete documents were causing the authorities to log warnings
about missing fields, and to do so very spammily.

We now detect the missing fields before tokenizing, and log at
debug.  This is a bit of ugliness, but it's probably a safer choice
than making _all_ unparseable-desc warnings into debug-level logs.

I'm looking at identity-ed25519 in extrainfos and proto in
routerdescs because they were (I believe) the latest-added fields in
Tor's history: any Tor that lacks them will also lack the other
newly required fields.

Fixes bug #40238; bugfix on 0.4.5.1-alpha.
9 jobs for bug40238_045 in 80 minutes and 48 seconds (queued for 27 minutes and 18 seconds)
latest
Status Job ID Name Coverage
  Test
passed #8082
debian-disable-dirauth

00:11:19

passed #8083
debian-disable-relay

00:13:39

passed #8078
debian-distcheck

00:07:09

passed #8079
debian-docs

00:04:11

failed #8077
debian-hardened

00:15:59

failed #8080
debian-integration

00:04:48

passed #8076
debian-minimal

00:09:54

passed #8084
debian-nss

00:05:45

passed #8081
debian-tracing

00:08:00

 
Name Stage Failure
failed
debian-integration Test
make[1]: Leaving directory '/builds/nickm/tor/build'
make: *** [Makefile:7343: all] Error 2
ERROR: command 'make -j4 -k all' has failed.
Uploading artifacts for failed job
Uploading artifacts...
artifacts/: found 1 matching files and directories

Uploading artifacts as "archive" to coordinator... ok
id=8080 responseStatus=201 Created token=gDFoepxm
Cleaning up file based variables
ERROR: Job failed: exit code 1
failed
debian-hardened Test
make[1]: Leaving directory '/builds/nickm/tor/build'
make: *** [Makefile:7346: all] Error 2
ERROR: command 'make -j4 -k all' has failed.
Uploading artifacts for failed job
Uploading artifacts...
artifacts/: found 1 matching files and directories

Uploading artifacts as "archive" to coordinator... ok
id=8077 responseStatus=201 Created token=LUguwMj7
Cleaning up file based variables
ERROR: Job failed: exit code 1