GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Better fix for #40241 (--enable-all-bugs-are-fatal and fallthrough)

This one should work on GCC _and_ on Clang.  The previous version
made Clang happier by not having unreachable "fallthrough"
statements, but made GCC sad because GCC didn't think that the
unconditional failures were really unconditional, and therefore
_wanted_ a FALLTHROUGH.

This patch adds a FALLTHROUGH_UNLESS_ALL_BUGS_ARE_FATAL macro that
seems to please both GCC and Clang in this case: ordinarily it is a
FALLTHROUGH, but when ALL_BUGS_ARE_FATAL is defined, it's an
abort().

Fixes bug 40241 again.  Bugfix on earlier fix for 40241, which was
merged into maint-0.3.5 and forward, and released in 0.4.5.3-rc.
19 jobs for bug40241_redux in 78 minutes and 18 seconds (queued for 38 minutes and 1 second)
latest
Status Job ID Name Coverage
  Test
passed #8708
debian-disable-dirauth

00:08:30

passed #8706
debian-distcheck

00:11:33

passed #8707
debian-docs

00:07:12

failed #8705
debian-hardened

00:12:26

passed #8398
debian-integration

00:20:29

passed #8704
debian-minimal

00:08:33

passed #8709
debian-nss

00:09:33

failed #8533
debian-disable-dirauth

00:00:09

failed #8399
debian-disable-dirauth

00:00:09

failed #8531
debian-distcheck

00:00:09

failed #8396
debian-distcheck

00:00:09

failed #8532
debian-docs

00:00:09

failed #8397
debian-docs

00:00:09

failed #8395
debian-hardened

00:00:09

failed #8530
debian-hardened

00:14:38

failed #8529
debian-minimal

00:00:10

failed #8394
debian-minimal

00:00:09

failed #8400
debian-nss

00:00:09

failed #8534
debian-nss

00:00:09

 
Name Stage Failure
failed
debian-hardened Test
make[1]: Leaving directory '/builds/nickm/tor/build'
make: *** [Makefile:5798: all] Error 2
ERROR: command 'make -j4 -k all' has failed.
Uploading artifacts for failed job
Uploading artifacts...
artifacts/: found 1 matching files and directories

Uploading artifacts as "archive" to coordinator... ok
id=8705 responseStatus=201 Created token=xgBoDsRb
Cleaning up file based variables
ERROR: Job failed: exit code 1