GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Try making our configure.ac script build with AC 2.70.

In versions <=2.69, according to the autoconf docs, AC_PROG_CC_C99
is needed with some compilers, if they require extra arguments to
build C99 programs.  In versions >=2.70, AC_PROG_CC checks for these
compilers automatically, and so the AC_PROG_CC_C99 macro is
obsolete.

So, what can you do if you want your script to work right with both
autoconf versions?  IIUC, neither including AC_PROG_CC_C99 macro nor
leaving it out will give you the right behavior with both versions.
It looks like you need to look at the autoconf version explicitly.

(Now, the autoconf manual implies that it's "against autoconf
philosophy" to look at the autoconf version rather than trying the
behavior to see if it works, but they don't actually tell you how to
detect recoverably at autoconf-time whether a macro is obsolete or
not, and I can't find a way to do that.)

So, is it safe to use m4_version_prereq, like I do here?  It isn't
listed in the autoconf 2.63 manual (which is the oldest version we
support).  But a mailing list message [1] (which added the
documentation back in 2008) implies that m4_version_prereq has been
there since "at least back to autoconf 2.59".

https://lists.gnu.org/archive/html/autoconf-patches/2008-12/msg00025.html

So I think this will work.

I am basing this patch against Tor 0.3.5 since, if autoconf 2.70
becomes widespread before 0.3.5 is unsupported, we might need this
patch to continue 0.3.5 development.  But I don't think we should
backport farther than 0.4.5 until/unless that actually happens.

This is part of a fix for #40355.
7 jobs for autoconf_270_035 in 22 minutes and 3 seconds (queued for 1 second)
latest
Status Job ID Name Coverage
  Test
failed #17117
debian-disable-dirauth

00:05:05

failed #17114
debian-distcheck

00:06:56

passed #17115
debian-docs

00:02:44

failed #17113
debian-hardened

00:08:17

passed #17116
debian-integration

00:19:18

failed #17112
debian-minimal

00:05:32

failed #17118
debian-nss

00:04:15

 
Name Stage Failure
failed
debian-nss Test
Test setuid failed!
FAIL src/test/test_switch_id.sh (exit status: 1)

FATAL ERROR: Failed tests: check
Uploading artifacts for failed job
Uploading artifacts...
artifacts/: found 2 matching files and directories

Uploading artifacts as "archive" to coordinator... ok
id=17118 responseStatus=201 Created token=Eo7PAxbs
ERROR: Job failed: exit code 1
failed
debian-disable-dirauth Test
Test setuid failed!
FAIL src/test/test_switch_id.sh (exit status: 1)

FATAL ERROR: Failed tests: check
Uploading artifacts for failed job
Uploading artifacts...
artifacts/: found 2 matching files and directories

Uploading artifacts as "archive" to coordinator... ok
id=17117 responseStatus=201 Created token=drx6x-g4
ERROR: Job failed: exit code 1
failed
debian-hardened Test
Test setuid failed!
FAIL src/test/test_switch_id.sh (exit status: 1)

FATAL ERROR: Failed tests: check
Uploading artifacts for failed job
Uploading artifacts...
artifacts/: found 2 matching files and directories

Uploading artifacts as "archive" to coordinator... ok
id=17113 responseStatus=201 Created token=mcrGoWsz
ERROR: Job failed: exit code 1
failed
debian-distcheck Test
/bin/bash: line 1: file: command not found
make: *** [Makefile:20505: show-distdir-core] Error 127
ERROR: command 'make show-distdir-core' has failed.
FATAL ERROR: Unable to continue.
Uploading artifacts for failed job
Uploading artifacts...
artifacts/: found 1 matching files and directories

Uploading artifacts as "archive" to coordinator... ok
id=17114 responseStatus=201 Created token=XzrxfF_J
ERROR: Job failed: exit code 1
failed
debian-minimal Test
Test setuid failed!
FAIL src/test/test_switch_id.sh (exit status: 1)

FATAL ERROR: Failed tests: check
Uploading artifacts for failed job
Uploading artifacts...
artifacts/: found 2 matching files and directories

Uploading artifacts as "archive" to coordinator... ok
id=17112 responseStatus=201 Created token=rpGHU9b4
ERROR: Job failed: exit code 1