Commit 986730e8 authored by David Goulet's avatar David Goulet 🐼
Browse files

test: Remove HSv2 protover specific test 



HSv2 is not advertised as a supported protocol version anymore.

This was introduced with the merge-forward of commit 72041c63
which didn't fix the unit test.

Fixes #40549

Signed-off-by: David Goulet's avatarDavid Goulet <dgoulet@torproject.org>
parent 4ab4521c

src/test/test_protover.c

+0 −9
Original line number Original line Diff line number Diff line
@@ -348,9 +348,6 @@ test_protover_supports_version(void *arg) 
/* Deprecated HSIntro versions */

/* Deprecated HSIntro versions */

#define PROTOVER_HS_INTRO_DEPRECATED_1 1

#define PROTOVER_HS_INTRO_DEPRECATED_1 1

#define PROTOVER_HS_INTRO_DEPRECATED_2 2

#define PROTOVER_HS_INTRO_DEPRECATED_2 2

/* Highest supported HSv2 introduce protocol version.

 * It's not clear if we actually support version 2, see #25068. */

#define PROTOVER_HS_INTRO_V2 3





/* HSv2 Rend and HSDir protocol versions. */

/* HSv2 Rend and HSDir protocol versions. */

#define PROTOVER_HS_RENDEZVOUS_POINT_V2 1

#define PROTOVER_HS_RENDEZVOUS_POINT_V2 1
@@ -433,12 +430,6 @@ test_protover_supported_protocols(void *arg) 
  tt_assert(!protocol_list_supports_protocol(supported_protocols,

  tt_assert(!protocol_list_supports_protocol(supported_protocols,

                                            PRT_HSINTRO,

                                            PRT_HSINTRO,

                                            PROTOVER_HS_INTRO_DEPRECATED_2));

                                            PROTOVER_HS_INTRO_DEPRECATED_2));

  /* We could test legacy HSIntro by calling rend_service_update_descriptor(),

   * and checking the protocols field. But that's unlikely to change, so

   * we just use a hard-coded value. */

  tt_assert(protocol_list_supports_protocol(supported_protocols,

                                            PRT_HSINTRO,

                                            PROTOVER_HS_INTRO_V2));

  /* Test for HSv3 HSIntro */

  /* Test for HSv3 HSIntro */

  tt_assert(protocol_list_supports_protocol(supported_protocols,

  tt_assert(protocol_list_supports_protocol(supported_protocols,

                                            PRT_HSINTRO,

                                            PRT_HSINTRO,