Commit a0404dad authored by Nick Mathewson's avatar Nick Mathewson 🤹
Browse files

r16691@tombo: nickm | 2008-07-03 11:04:03 -0400 

 Backport to 0.1.2: Fix for bug 742: do not use O_CREAT on 2-option version of open().  Especially do not use it on /dev/null.  Fix from Michael Scherer. Bugfix on 0.0.2pre19 (wow).


svn:r15628
parent 34037399

ChangeLog

+3 −0
Original line number Diff line number Diff line
@@ -30,6 +30,9 @@ Changes in version 0.1.2.20 - 2008-??-?? 
    - Fix a dumb bug that was preventing us from knowing that we should

      preemptively build circuits to handle expected directory requests.

      Fixes bug 660.

    - When opening /dev/null in finish_daemonize(), do not pass the

      O_CREAT flag.  Fortify was complaining, and correctly so.  Fixes

      bug 742; fix from Michael Scherer.  Bugfix on 0.0.2pre19.



  o Minor testing features:

    - Add disabled-by-default code to log the relative probability of routing

src/common/util.c

+1 −2
Original line number Diff line number Diff line
@@ -2070,8 +2070,7 @@ finish_daemon(const char *desired_cwd) 
    exit(1);

  }



  nullfd = open("/dev/null",

                O_CREAT | O_RDWR | O_APPEND);

  nullfd = open("/dev/null", O_RDWR | O_APPEND);

  if (nullfd < 0) {

    log_err(LD_GENERAL,"/dev/null can't be opened. Exiting.");

    exit(1);