Unverified Commit 3546fd92 authored by VeNoMouS's avatar VeNoMouS Committed by GitHub
Browse files

improvement: cleanup (#253) 

u_common.go:
* Move if statement into existing switch case
* Remove comment about keepPSK

u_fingerprinter.go:
* Remove comment about KeepPSK
parent e89d82cd

u_common.go

+2 −5
Original line number Diff line number Diff line
@@ -208,8 +208,6 @@ func (chs *ClientHelloSpec) ReadCompressionMethods(compressionMethods []byte) er 


// ReadTLSExtensions is a helper function to construct a list of TLS extensions from

// a byte slice into []TLSExtension.

//

// If keepPSK is not set, the PSK extension will cause an error.

func (chs *ClientHelloSpec) ReadTLSExtensions(b []byte, allowBluntMimicry bool, realPSK bool) error {

	extensions := cryptobyte.String(b)

	for !extensions.Empty() {
@@ -233,12 +231,11 @@ func (chs *ClientHelloSpec) ReadTLSExtensions(b []byte, allowBluntMimicry bool, 
				} else {

					extWriter = &FakePreSharedKeyExtension{}

				}

			}



			if extension == extensionSupportedVersions {

			case extensionSupportedVersions:

				chs.TLSVersMin = 0

				chs.TLSVersMax = 0

			}



			if _, err := extWriter.Write(extData); err != nil {

				return err

			}

u_fingerprinter.go

+0 −1
Original line number Diff line number Diff line
@@ -8,7 +8,6 @@ package tls 
type Fingerprinter struct {

	// AllowBluntMimicry will ensure that unknown extensions are

	// passed along into the resulting ClientHelloSpec as-is

	// It will not ensure that the PSK is passed along, if you require that, use KeepPSK

	// WARNING: there could be numerous subtle issues with ClientHelloSpecs

	// that are generated with this flag which could compromise security and/or mimicry

	AllowBluntMimicry bool