Commit 301ffb71 authored by David Goulet's avatar David Goulet 🤘
Browse files

hs: Send back 0xF6 for a v2 onion address



Fixes #40421

Signed-off-by: David Goulet's avatarDavid Goulet <dgoulet@torproject.org>
parent 45c8d69c
o Minor bugfixes (onion service):
- Send back the extended SOCKS error 0xF6 for a v2 onion address. Fixes bug
40421; bugfix on 0.4.6.2-alpha.
......@@ -2536,6 +2536,10 @@ connection_ap_handshake_rewrite_and_attach(entry_connection_t *conn,
"https://blog.torproject.org/v2-deprecation-timeline.");
control_event_client_status(LOG_WARN, "SOCKS_BAD_HOSTNAME HOSTNAME=%s",
escaped(socks->address));
/* Send back the 0xF6 extended code indicating a bad hostname. This is
* mostly so Tor Browser can make a proper UX with regards to v2
* addresses. */
conn->socks_request->socks_extended_error_code = SOCKS5_HS_BAD_ADDRESS;
connection_mark_unattached_ap(conn, END_STREAM_REASON_TORPROTOCOL);
return -1;
}
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment