Commit 49e7cec0 authored by sickcodes's avatar sickcodes
Browse files

Update connection_edge.c

For the tor-browser specifically, the visual "Got it" appears once per session and is sufficient as per informative report 1250273.

Comment in 301ffb71 regarding proper UX has been satisfied by Warning page.

Still return 0xF6, so no need to log in `--verbose`.

Reverts 5e836eb8

Needs to also fix 80c404c4

Signed-off-by: sickcodes's avatarSick Codes <>
parent 82168e5e
Pipeline #12578 failed with stage
in 20 minutes and 45 seconds
......@@ -2530,10 +2530,6 @@ connection_ap_handshake_rewrite_and_attach(entry_connection_t *conn,
/* We don't support v2 onions anymore. Log a warning and bail. */
if (addresstype == ONION_V2_HOSTNAME) {
log_warn(LD_PROTOCOL, "Tried to connect to a v2 onion address, but this "
"version of Tor no longer supports them. Please encourage the "
"site operator to upgrade. For more information see "
control_event_client_status(LOG_WARN, "SOCKS_BAD_HOSTNAME HOSTNAME=%s",
/* Send back the 0xF6 extended code indicating a bad hostname. This is
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment