Skip to content
  • Grisha Kruglov's avatar
    Closes #7450: Lazy storage initialization · eb14532c
    Grisha Kruglov authored
    Make sure that we actually lazily initialize our storage layers.
    
    With this patch applied, storage layers (history, logins, bookmarks) will be initialized when first
    accessed. We will no longer block GeckoEngine init, for example, on waiting for the logins storage
    to initialize (which needs to access the costly securePrefStorage).
    Similarly, BackgroundServices init will no longer require initialized instances of the storage
    components - references to their "lazy wrappers" will suffice.
    
    In practice, this change changes when our storage layers are initialized in the following ways.
    Currently, we will initialize everything on startup. This includes loading our megazord, as well.
    
    With this change, init path depends on if the user is signed-into FxA or not.
    
    If user is not an FxA user:
    - on startup, none of the storage layers are initialized
    - history storage will be initialized once, whenever:
      - first non-customTab page is loaded (access to the HistoryDelegate)
      - first interaction with the awesomebar
      - history UI is accessed
    - bookmarks storage will be initialized once, whenever:
      - something is bookmarked, or we need to figure out if something's bookmarked
      - bookmarks UI is accessed
    - logins storage will be initialized once, whenever:
      - first page is loaded with a login/password fields that can be autofilled
      - (or some other interaction by GV with the autofill/loginStorage delegates)
      - logins UI is accessed
    - all of these storages will be initialized if the user logs into FxA and starts syncing data
      - except, if a storage is not chosen to be synced, it will not be initialized
    
    If user is an FxA user:
    - on startup, none of the storage layers are initialized
    - sometime shortly after startup is complete, when a sync worker runs in the background, all storage
    layers that are enabled to sync will be initialized.
    
    This change also means that we delay loading the megazord until first access (as described above).
    eb14532c