1. 02 Jan, 2020 2 commits
  2. 30 Dec, 2019 1 commit
  3. 20 Dec, 2019 1 commit
  4. 16 Dec, 2019 1 commit
  5. 13 Dec, 2019 2 commits
  6. 10 Dec, 2019 1 commit
  7. 09 Dec, 2019 1 commit
  8. 04 Dec, 2019 2 commits
  9. 28 Nov, 2019 1 commit
  10. 26 Nov, 2019 1 commit
  11. 25 Nov, 2019 1 commit
  12. 24 Nov, 2019 1 commit
  13. 22 Nov, 2019 1 commit
  14. 19 Nov, 2019 1 commit
  15. 18 Nov, 2019 1 commit
  16. 14 Nov, 2019 1 commit
  17. 12 Nov, 2019 1 commit
    • Severin Rudie's avatar
      4281 remove qab (#6310) · 6909a76b
      Severin Rudie authored
      * For #4281: small ToolbarMenu refactor
      
      This makes it easier to see how items are ordered in the menuItems list
      
      * For 4281: add QAB buttons to menu
      
      * For 4281: removed menu back button per mocks
      
      I double checked with UX, and we'll be relying on the hardware back button for its functionality
      
      * For 4281: add content descriptions for bookmarking
      
      * For 4281: updated BrowserToolbarController for new functionality
      
      * For 4281: provided simple dependencies to browser controller
      
      More complex changes will be in a following commit, for review readability
      
      * For 4281: move toolbar controller dependencies up to BaseBrowserFragment
      
      The functionality they control is being moved into the toolbar menu, which is shared by both normal tabs and custom ones
      
      * For 4281: removed (now unused) code related to QAB
      
      * For 4281: fix test compilation after QAB removal
      
      Tests still need to be expanded to include added functionality
      
      * For 4281: updated menu to show if url is bookmarked
      
      This sloppy workaround is required because TwoStateButton requires that `isInPrimaryState` be a synchronous call, and checking whether or not the current site is bookmarked is quite slow (10-50 MS, in my tests).  After days of work and many attempted solutions, this was the least abhorrent among them.
      
      https://github.com/mozilla-mobile/android-components/issues/4915 was opened against AC to evaluate potentially supporting async `isInPrimaryState` functions.
      https://github.com/mozilla-mobile/fenix/issues/6370 was opened against Fenix to investigate the unexpectedly slow call to `BookmarkStorage`.
      
      * For 4281: update reader mode switch
      
      * For 4281: selectively show/hide menu items
      
      * For 4281: add reader mode appearance
      
      * For 4281: update bookmark button when it is clicked
      
      * For 4281: removed unused QAB code
      
      * For 4281: removed QAB robot, updated UI tests
      
      * For 4281: removed QuickActionSheet metrics
      
      Since this behavior now lives in the toolbar, it is tracked via Event.BrowserMenuItemTapped
      
      * For 4281: fixed lint errors
      
      * For 4281: add new strings for buttons added to menu
      
      This is necessary because the location change (from QAB to toolbar menu) could affect the grammar in some languages
      
      * For 4281: remove outdated TODOs
      
      * For 4281: removed QAB container
      
      * For 4281: removed back button reference from UI test
      
      This button no longer exists
      
      * For 4821: Fixes a visual defect (extra padding on top of toolbar)
      
      * For 4281: update copy on reader mode
      
      * For 4281: fixed review nits
      6909a76b
  18. 11 Nov, 2019 2 commits
  19. 06 Nov, 2019 1 commit
  20. 01 Nov, 2019 1 commit
  21. 31 Oct, 2019 1 commit
  22. 25 Oct, 2019 1 commit
  23. 24 Oct, 2019 1 commit
  24. 23 Oct, 2019 2 commits
    • mawen7's avatar
    • Severin Rudie's avatar
      #4596 migrate collections (#5911) · aa8642f5
      Severin Rudie authored
      * For #4596: move code from CollectionCreationComponent to CollectionCreationStore
      
      Other than adding comments, no changes were made. The code will be updated in a following commit. This is in order to make the commit diff more readable.
      
      * For 4596: update CollectionCreateStore to libstate
      
      * For 4596: copied CollectionCreationUIView into CollectionCreationView
      
      Otherwise, no code was changed. The next commit will update this code. This is in order to make the commit diff more readable.
      
      * For 4596: update CollectionCreationView to LibState
      
      Note that the minimal changes possible to enable migration were made.  Refactoring will happen in a later commit.
      
      * For 4596: updated CollectionCreationTabListAdapter to work with the new View
      
      * For 4596: updated SaveCollectionListAdapter to work with the new View
      
      * For 4596: implemented CollectionCreationController
      
      For now, it has an identical interface to the interactor. In a later commit several of its responsibilities will be moved around, some to the interactor and some to the reducer
      
      * For 4596: copied over previous reducer code
      
      No other changes were made. The code will be updated in the following commit. This is done to make changes more readable for the reviewer
      
      * For 4596: update reducer code param names
      
      Otherwise, no changes at this time
      
      * For 4596: add arguments to CreateCollectionFragment in nav_graph
      
      These will be used to replace the current CreateCollectionViewModel, which shares data between fragments in a way that doesn't fit within our architecture.
      
      * For 4596: pass arguments to collection via transaction instead of VM
      
      The VM will be removed in a later commit
      
      * For 4596: update BrowserToolbarController to share state to collection via its Direction
      
      * For 4596: removed CreateCollectionViewModel
      
      * For 4596: test tab retrieval in CreateCollectionFragment
      
      * For 4596: fix crashing CreateCollectionFragmentTest
      
      * For 4596: removed classes create collection classes used by old architecture
      
      * For 4596: collection interactor rename + kdoc
      
      * For 4596: moved collection interactor interface
      
      * For 4596: renamed CreateCollectionFragment
      
      All related classes followed the pattern of CollectionCreationX
      
      * For 4596: kdoc CollectionCreationController
      
      There's no effective difference between these calls and their interactor equivalent, so I linked to them
      
      * For 4596: fix bug that caused rename to not work
      
      * For 4596: removed unused collection actions
      
      These were unused before the LibState refactor
      
      * For 4596: kdoc StepChanged
      
      * For 4596: removed todos about moving logic to the reducer
      
      saveTabsToCollection: this could be moved, but that would involve creating a new action. SaveCollectionStep should probably be refactored out, so adding this layer of indirection seemed counterproductive
      
      handleBackPress: needs to be able to call dismiss(). The reducer doesn't (and shouldn't) be able to do that, so this needs to live here
      
      stepBack: called by handleBackPress. See above
      
      * For 4596: wrote tests for CollectionCreationController#stepback
      
      * For 4596: fixed tests broken by changes to collections
      
      * For 4596: small readability refactor for CollectionController#stepBack
      
      No change to functionality (see tests)
      
      * For 4596: broke apart CollectionView#update
      
      There's probably a lot more that could be done here, but smaller changes were made to reduce scope
      
      * For 4596: remove unnecessary todos
      
      It looks like we don't follow the suggested pattern in this project
      
      * For 4596: test CollectionCreationController#normalSessionSize
      
      * For 4596: updated naming in CollectionCreationController per review
      aa8642f5
  25. 22 Oct, 2019 1 commit
  26. 21 Oct, 2019 1 commit
  27. 15 Oct, 2019 1 commit
  28. 14 Oct, 2019 1 commit
  29. 11 Oct, 2019 1 commit
  30. 09 Oct, 2019 1 commit
  31. 07 Oct, 2019 1 commit
  32. 03 Oct, 2019 1 commit
  33. 01 Oct, 2019 1 commit
  34. 30 Sep, 2019 1 commit
  35. 27 Sep, 2019 1 commit