1. 02 Jan, 2020 1 commit
  2. 12 Dec, 2019 1 commit
  3. 10 Dec, 2019 1 commit
  4. 26 Nov, 2019 1 commit
  5. 25 Nov, 2019 1 commit
  6. 20 Nov, 2019 1 commit
    • Jeff Boek's avatar
      Adds custom search engines (#6551) · 607c3d4c
      Jeff Boek authored
      * For #5577 - Adds button to add a new search engine
      
      * For #5577 - Adds custom engine store
      
      * For #5577 - Creates a custom SearchEngineProvider
      
      * For #5577 - Gives the ability to delete search engines
      
      * For #5577 - Adds the UI to add a custom search engine
      
      * For #5577 - Adds form to create a custom search engine
      
      * For #5577 - Adds the ability to add a custom search engine
      
      *  For #5577 - Adds the ability to delete custom search engines
      
      * For #5577 - Selects the first element on the add custom search engine screen
      
      * For #5577 - Prevents adding a search engine that already exists
      
      * For #5577 - Styles the add search engine preference
      
      * For #5577 - Makes the name check case-insensitive
      
      * For #5577 - Fix bug where home screen doesnt see new search engines
      
      * For #5577 - Moves Search URL validation to its own type
      
      * For #5577 - Fixes linting errors
      
      * For #5577 - Adds the ability to edit a custom search engine
      
      * For #5577 - Allows the user to edit a serach engine even when it is the last item in the list
      
      * For #5577 - Adds an undo snackbar when deleting a search engine
      
      * For #5577 - Moves all of the strings to be translated
      
      * For #5577 - Fixes bug when deleting your default search engine
      
      * For #5577 - Puts adding search engines behind a feature flag
      
      * For #5577 - Navigate to custom search engine SUMO article when tapping learn more
      
      * For #5577 - Fixes nits
      
      * For #5577 - Uses concept-fetch to validate search string
      
      * For #5577 - Adds string resources for the cannot reach error state
      607c3d4c
  7. 12 Nov, 2019 1 commit
  8. 08 Nov, 2019 1 commit
  9. 31 Oct, 2019 1 commit
  10. 24 Oct, 2019 1 commit
  11. 23 Oct, 2019 1 commit
    • Severin Rudie's avatar
      #4596 migrate collections (#5911) · aa8642f5
      Severin Rudie authored
      * For #4596: move code from CollectionCreationComponent to CollectionCreationStore
      
      Other than adding comments, no changes were made. The code will be updated in a following commit. This is in order to make the commit diff more readable.
      
      * For 4596: update CollectionCreateStore to libstate
      
      * For 4596: copied CollectionCreationUIView into CollectionCreationView
      
      Otherwise, no code was changed. The next commit will update this code. This is in order to make the commit diff more readable.
      
      * For 4596: update CollectionCreationView to LibState
      
      Note that the minimal changes possible to enable migration were made.  Refactoring will happen in a later commit.
      
      * For 4596: updated CollectionCreationTabListAdapter to work with the new View
      
      * For 4596: updated SaveCollectionListAdapter to work with the new View
      
      * For 4596: implemented CollectionCreationController
      
      For now, it has an identical interface to the interactor. In a later commit several of its responsibilities will be moved around, some to the interactor and some to the reducer
      
      * For 4596: copied over previous reducer code
      
      No other changes were made. The code will be updated in the following commit. This is done to make changes more readable for the reviewer
      
      * For 4596: update reducer code param names
      
      Otherwise, no changes at this time
      
      * For 4596: add arguments to CreateCollectionFragment in nav_graph
      
      These will be used to replace the current CreateCollectionViewModel, which shares data between fragments in a way that doesn't fit within our architecture.
      
      * For 4596: pass arguments to collection via transaction instead of VM
      
      The VM will be removed in a later commit
      
      * For 4596: update BrowserToolbarController to share state to collection via its Direction
      
      * For 4596: removed CreateCollectionViewModel
      
      * For 4596: test tab retrieval in CreateCollectionFragment
      
      * For 4596: fix crashing CreateCollectionFragmentTest
      
      * For 4596: removed classes create collection classes used by old architecture
      
      * For 4596: collection interactor rename + kdoc
      
      * For 4596: moved collection interactor interface
      
      * For 4596: renamed CreateCollectionFragment
      
      All related classes followed the pattern of CollectionCreationX
      
      * For 4596: kdoc CollectionCreationController
      
      There's no effective difference between these calls and their interactor equivalent, so I linked to them
      
      * For 4596: fix bug that caused rename to not work
      
      * For 4596: removed unused collection actions
      
      These were unused before the LibState refactor
      
      * For 4596: kdoc StepChanged
      
      * For 4596: removed todos about moving logic to the reducer
      
      saveTabsToCollection: this could be moved, but that would involve creating a new action. SaveCollectionStep should probably be refactored out, so adding this layer of indirection seemed counterproductive
      
      handleBackPress: needs to be able to call dismiss(). The reducer doesn't (and shouldn't) be able to do that, so this needs to live here
      
      stepBack: called by handleBackPress. See above
      
      * For 4596: wrote tests for CollectionCreationController#stepback
      
      * For 4596: fixed tests broken by changes to collections
      
      * For 4596: small readability refactor for CollectionController#stepBack
      
      No change to functionality (see tests)
      
      * For 4596: broke apart CollectionView#update
      
      There's probably a lot more that could be done here, but smaller changes were made to reduce scope
      
      * For 4596: remove unnecessary todos
      
      It looks like we don't follow the suggested pattern in this project
      
      * For 4596: test CollectionCreationController#normalSessionSize
      
      * For 4596: updated naming in CollectionCreationController per review
      aa8642f5
  12. 10 Oct, 2019 1 commit
  13. 08 Oct, 2019 1 commit
  14. 03 Oct, 2019 2 commits
  15. 20 Sep, 2019 1 commit
  16. 19 Sep, 2019 1 commit
  17. 18 Sep, 2019 1 commit
  18. 11 Sep, 2019 6 commits
  19. 10 Sep, 2019 1 commit
  20. 03 Sep, 2019 2 commits
  21. 23 Aug, 2019 1 commit
  22. 19 Aug, 2019 1 commit
  23. 15 Aug, 2019 1 commit
  24. 14 Aug, 2019 1 commit
  25. 09 Aug, 2019 1 commit
  26. 05 Aug, 2019 1 commit
  27. 02 Aug, 2019 1 commit
  28. 26 Jul, 2019 1 commit
  29. 22 Jul, 2019 1 commit
  30. 18 Jul, 2019 1 commit
  31. 15 Jul, 2019 1 commit
  32. 11 Jul, 2019 1 commit
  33. 10 Jul, 2019 1 commit