When bumping mingw-w64 for the crash fix in #28874 we forgot to adapt
our Windows mozconfig files to take into account that we don't need to
define CXXFLAGS anymore. The changes landed in commit
a91a7e405752bbdbe39101f7aaeb1e1d932199db in the mingw-w64 repo.

Remove the python3.6-lxml package for the list of dependencies to build
https-everywhere. This package does not exist anymore in Debian Buster,
and it seems it is not required to build https-everywhere.

Which should have been "bug_28618_v3", but the changes are okay at
least...

Richard Pospesel authored Nov 28, 2018 and boklm committed Jan 23, 2019

This patch passes in the build channel to makensis as a !define so that
the tbb-windows-installer torbrowser.nsi installer script can use
appropriate branding and set branding-specific names and install paths.

Richard Pospesel authored Nov 20, 2018 and Georg Koppen committed Jan 21, 2019

Updated firefox build and config to pass appropriate path for
tor-browser branding using the --with-branding ./mach configure flag.

Richard Pospesel authored Jan 15, 2019 and Georg Koppen committed Jan 21, 2019

Updated the https-everywhere deps section to install python3.6 and
python3.6-lxml. Previously python and python-lxml were listed, but these
packages now map to the 3.7 versions.

This reverts commit 49eb43da.

No longer needed after we bumped the binutils version to 2.32.1 in
bug 26148.

With older versions of binutils, the order in which .o files were
included in an .a archive did not affect the output when linking a
program or library, which is no longer the case with recent versions of
binutils. To avoid reproducibility issues we patch the libtool version
included in gcc to make the creation `libstdc++.a` reproducible.

The NoScript update fixes #28873 and #28720 on our side.

David Fifield authored Dec 20, 2018 and Georg Koppen committed Dec 20, 2018

This is supposed to remove and reset modified or unversioned files. This
ought to work around the problem with versioning of src/testing/gmock
and src/testing/gtest across upgrades.

$ gclient help sync
  -f, --force      force update even for unchanged modules
  -D, --delete_unversioned_trees
                   Deletes from the working copy any dependencies that
                   have been removed since the last sync, as long as
                   there are no local modifications. When used with
                   --force, such dependencies are removed even if they
                   have local modifications. When used with --reset, all
                   untracked directories are removed from the working
                   copy, excluding those which are explicitly ignored in
                   the repository.
  -R, --reset      resets any local changes before updating (git only)

Thanks to a cypherpunk for mentioning the missing pointer events item
on the blog.

Thanks to a cypherpunk on our blog for spotting that one.

David Fifield authored Dec 03, 2018 and Georg Koppen committed Dec 07, 2018

This necessitates an upgrade to webrtc to branch-heads/64. Compare to:
https://github.com/keroserene/go-webrtc/commit/1ca4087bc01b9a6726a68c72ac541b03a91c4c7b

-D_GLIBCXX_USE_CXX11_ABI=1 is no longer required, as the default has
changed:
https://github.com/keroserene/go-webrtc/commit/a3140c36f9933013ad2e66bc21358a1bfea95a95

I needed to add libgtk-3-dev as a build dependency for webrtc.
libgtk-3-dev appears in src/build/install-build-deps.sh.

I also had to upgrade depot_tools to
7d9d9233cb657e968831238346917b0b64abb4c1. I got the commit ID from
src/DEPS in the webrtc source. Without upgrading depot_tools, I got this
error from gclient:
	Error: 1> dependency url must be either a string, None, File() or From() instead of dict

I needed to add a command to delete src/testing/{gmock,gtest}; otherwise
"gclient sync" complains about overwriting unversioned files.
https://bugs.torproject.org/25483#comment:15
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_25483_v0&id=d5514f7f3b566cf37bfc59ec8105a96130577ff2
The error is
	src/testing (ERROR)
	----------------------------------------
	[0:00:00] Started.
	[0:00:01] From https://chromium.googlesource.com/chromium/src/testing
	[0:00:01]    7d7436a8..9805faa0  master     -> origin/master
	----------------------------------------
	Error: Command 'git checkout --quiet 60c665fffe7dc505fdd5d30f9dbcbc50dde1e017' returned non-zero exit status 1 in /home/user/tor-browser-build/gclient/webrtc/src/testing
	error: The following untracked working tree files would be overwritten by checkout:
		gmock/include/gmock/gmock-actions.h
		gmock/include/gmock/gmock-generated-function-mockers.h
		gmock/include/gmock/gmock-matchers.h
		gmock/include/gmock/gmock.h
		gtest/include/gtest/gtest-death-test.h
		gtest/include/gtest/gtest-message.h
		gtest/include/gtest/gtest-param-test.h
		gtest/include/gtest/gtest-spi.h
		gtest/include/gtest/gtest.h
		gtest/include/gtest/gtest_prod.h
	Please move or remove them before you switch branches.
	Aborting

With #26843 we now require mercurial to be installed, so it should be
installed by the tbb-build ansible role.

Changelog update and versions bump

If we are using faketime on Stretch when signing our debug .apk the
build freezes for unknown reasons on some machines. Switching to Buster
avoids that.

boklm authored Dec 06, 2018 and Georg Koppen committed Dec 06, 2018

The json file used by projects/firefox-locale-bundle is only available
from https://product-details.mozilla.org/ after a build has been
shipped, which is too late for us. However, it is also available from
the firefox sources tree, so we can get it from our tor-browser.git
clone instead.

The format of this json file is a little different, so we also need to
adapt the get_hg_hash script.