GitLab

Sukhbir Singh authored Jun 17, 2018 and boklm committed Jun 19, 2018

This commit adds support for building the 64-bit version of NSIS, and
also bumps the version to 3.03. Doing this enables us to build MAR files
in a 64-bit container for the 64-bit version of Tor Browser; see bug
26363 and bug 24477.

The pe_checksum_fix.py doesn't work in a 64-bit container with the
bundled python-pefile version so we build its latest version to fix this
issue. This change is borrowed from commit bb32ec91 and updates
python-pefile to 2017.11.5.

The Debian package and the patches are no longer required as all changes
were merged upstream in 3.01-1. (See the nsis changelog in Debian.)

Mozilla switched from Bzip2 to LZMA as compression algorithm for MAR
files during th Firefox 56. That means esr52-based Tor Browsers don't
understand LZMA yet. Thus, we still use Bzip2 for the first esr60-based
MAR files and switch afterwards to LZMA.

sandboxed-tor-browser is not maintained anymore and Yawning requested to
not ship it anymore in our alphas once we switch to Firefox 60 ESR.

Bumping Rust to 1.26.1 avoids intermittent Firefox compilation failures
we have seen, similar to those Mozilla got and documented in
https://bugzilla.mozilla.org/show_bug.cgi?id=1445413.

The fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1443823 makes
our workaround for https://bugzilla.mozilla.org/show_bug.cgi?id=1392604
obsolete, and we can remove it as it landed on esr60.

Sukhbir Singh authored Jun 12, 2018 and Georg Koppen committed Jun 14, 2018

Also enable rust for all builds.

Sukhbir Singh authored Jun 14, 2018 and Georg Koppen committed Jun 14, 2018

This commit adds support for building and bundling fxc2 which is
required for Windows cross-compilation on Linux.

We were setting the minSupportedInstructionSet attribute for the win32
updates only. We now set it on all platforms.

Add the htaccess_rewrite_rules option which can be used to specify
rewrite rules to be added to the generated .htaccess files.

The 32bit toolchain is not able to link libxul anymore with selfrando
enabled as the linker is running out of address space. We therefore
disable selfrando for 32bit for now.

After building Firefox we now get a 'Tor Browser.app' instead of a
'TorBrowser.app'. This patch makes sure the additional whitespace in the
app name is correctly handled by the build script and the one that deals
with packaging the final bundle.

We need to ship a fix for the Firefox packaging step as well as
|./mach package| wants to build the final .dmg in that step, too, which
breaks: there is no .dmg creation tool available. Setting
`INNER_MAKE_PACKAGE` to `true` does not seem to work anymore. That part
of this patch is currently only a workaround to get the nightly builds
going. We should come up with a better solution that allows us to skip
that part of the Firefox packaging step on all supported platforms.

This commit fixes #26153 by bumping the selfrando version to 0.4.2

Georg Koppen authored Jun 04, 2018 and boklm committed Jun 06, 2018

The snowflake build system is pretty complicated. We disable this pluggable
transport for now to get time to adapt it to the new macOS toolchain while
not blocking our nightly builds. See bug 26251 for work on that.

Avoid duplicating Windows CFLAGS and LDFLAGS. Instead, use the flags
defined in rbm.conf.

This also means we are now using -fstack-protector-strong instead of
-fstack-protector-all for building openssl.

We update the CFLAGS/LDFLAGS defined in rbm.conf to move
var/flag_mwindows at the end, because openssl's Configure script does
not like having an argument starting with a space.