Georg Koppen authored Nov 16, 2018 and boklm committed Nov 16, 2018

Additionally, minor clean-ups got done (like adding our 64bit Windows
target where needed).

sisbell authored Nov 16, 2018 and Georg Koppen committed Nov 16, 2018

The script got written by boklm.

As rbm currently does not do deep merge of options hashes (bug 26185) we
cannot modify var/* options from the input_files section (or we lose all
the other var/* options). As a workaround we move the two options we
need to modify under input_file_var/ instead of var/.

Adding Alexis' and keeping only Bill's in addition to that

David Fifield authored Oct 31, 2018 and Georg Koppen committed Oct 31, 2018

This avoids a harmless error message in the build log:
find: `talk/': No such file or directory

Compare to
https://github.com/keroserene/go-webrtc/commit/bfbd31b3f439346e9cac73df05781be9a51b0e45#diff-0b83f9dedf40d7356e5ca147a077acb4

The update to go 1.11.1 fixed part of #27827, namely the
/tmp/go-buildRANDOMNUM paths embedded in the binary. However there is
still a single /tmp/go-link-RANDOMNUM/go.o path remaining -- it comes
from here:
https://github.com/golang/go/blob/go1.11.1/src/cmd/link/internal/ld/lib.go#L935-L946
The random path affects the Go build ID even if we overwrite the random
digits in the binary.

Luckily there's a -tmpdir flag that lets us override the random path.

For some reason, this version of go requires setting
_GLIBCXX_USE_CXX11_ABI=1 in the snowflake build, not only in go-webrtc.
https://bugs.torproject.org/27827#comment:12

This reverts commit 6803d9a8.

This reverts commit fbb72c65.

This reverts commit 889be431, reversing
changes made to d8ce7fca.

The patch for bug 27827 leads to a busted Linux build.

Versions bump and Changelog update

The update to go 1.11.1 fixed part of #27827, namely the
/tmp/go-buildRANDOMNUM paths embedded in the binary. However there is
still a single /tmp/go-link-RANDOMNUM/go.o path remaining -- it comes
from here:
https://github.com/golang/go/blob/go1.11.1/src/cmd/link/internal/ld/lib.go#L935-L946
The random path affects the Go build ID even if we overwrite the random
digits in the binary.

Luckily there's a -tmpdir flag that lets us override the random path.

Update tbb-windows-installer to v0.5, adding patch to abort install if
CPU is missing SSE2 support.

Use a new .DS_Store file that has the correct app icon position.
Incorporate a new background image with updated Tor Browser branding,
  including @1x and @2x (Retina) images.
Remove the .fseventsd/ directory, which is not needed in a DMG.
These changes also fix bug 25151: Update Tor Browser branding on
  installation.

Georg Koppen authored Oct 15, 2018 and boklm committed Oct 16, 2018

We use `/usr/bin/env` for invocation in other scripts already. Let's use
it in `execdesktop` as well.

Building Rust with Thin LTO enabled leads to Tor Browser builds on macOS
and probably Linux not being reproducible. The exact reason for that is
unknown at the moment, although it seems fixed testing nightly Rust
source tarballs as of mid-September 2018.

We therefore disable Thin LTO for now by setting `codegen-units` to `1`.

The Windows installer for the en-US bundle was created from the
$TB_STAGE_DIR instead of the $PKG_DIR where the precomplete file has
been regenerated.

These binaries were already being built but were being discarded.
Since reproducible builds of these tools are likely to be useful to
some people (even though they're not required for Tor Browser to
operate), it seems like they're worth distributing.

They're placed in the mar-tools zip because that's where certutil was
already being placed.