Bug 481777. Don't fire DOMTitleChanged events to content. r+sr=smaug (016861a6) · Commits · Tommy Webb / Tor Browser

content/base/src/nsDocument.cpp

+3 −3

Original line number	Diff line number	Diff line
		@@ -5045,7 +5045,7 @@ nsDocument::DoNotifyPossibleTitleChange()
		}

		// Fire a DOM event for the title change.
		nsContentUtils::DispatchTrustedEvent(this, static_cast<nsIDocument*>(this),
		nsContentUtils::DispatchChromeEvent(this, static_cast<nsIDocument*>(this),
		NS_LITERAL_STRING("DOMTitleChanged"),
		PR_TRUE, PR_TRUE);
		}

content/base/test/chrome/Makefile.in

+2 −0

Original line number	Diff line number	Diff line
		@@ -52,6 +52,8 @@ _CHROME_FILES = \
		test_bug429785.xul \
		test_bug430050.xul \
		test_bug467123.xul \
		test_title.xul \
		title_window.xul \
		$(NULL)

		libs:: $(_TEST_FILES)

content/base/test/chrome/test_title.xul

0 → 100644

+32 −0

Original line number	Diff line number	Diff line
		<?xml version="1.0"?>
		<?xml-stylesheet type="text/css" href="chrome://global/skin"?>
		<?xml-stylesheet href="chrome://mochikit/content/tests/SimpleTest/test.css"
		type="text/css"?>
		<!--
		https://bugzilla.mozilla.org/show_bug.cgi?id=481777
		-->
		<window title="Mozilla Bug 481777"
		xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">
		<script type="application/javascript"
		src="chrome://mochikit/content/MochiKit/packed.js"></script>
		<script type="application/javascript"
		src="chrome://mochikit/content/tests/SimpleTest/SimpleTest.js"></script>

		<!-- test results are displayed in the html:body -->
		<body xmlns="http://www.w3.org/1999/xhtml">
		<a href="https://bugzilla.mozilla.org/show_bug.cgi?id=481777"
		target="_blank">Mozilla Bug 481777</a>
		</body>

		<!-- test code goes here -->
		<script type="application/javascript">
		<![CDATA[

		/ Test for Bug 481777 /

		SimpleTest.waitForExplicitFinish();
		window.open("title_window.xul", "bug481777",
		"chrome,width=100,height=100");
		]]>
		</script>
		</window>

content/base/test/chrome/title_window.xul

0 → 100644

+178 −0

Original line number	Diff line number	Diff line
		<?xml version="1.0"?>
		<?xml-stylesheet type="text/css" href="chrome://global/skin"?>
		<window title="Mozilla Bug 481777 subwindow"
		xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
		onload="runTests()">

		<iframe type="content" id="html1" src="data:text/html,<html><head><title id='t'>Test</title></head></html>"/>
		<iframe type="content" id="html2" src="data:text/html,<html><head><title id='t'>Test</title><title>Foo</title></head></html>"/>
		<iframe type="content" id="html3" src="data:text/html,<html></html>"/>
		<iframe type="content" id="xhtml1" src="data:text/xml,<html xmlns='http://www.w3.org/1999/xhtml'><body><title id='t'>Test</title></body></html>"/>
		<iframe type="content" id="xhtml2" src="data:text/xml,<title xmlns='http://www.w3.org/1999/xhtml'>Test</title>"/>
		<iframe type="content" id="xhtml3" src="data:text/xml,<title xmlns='http://www.w3.org/1999/xhtml'>Te<div>bogus</div>st</title>"/>
		<iframe type="content" id="xhtml4" src="data:text/xml,<html xmlns='http://www.w3.org/1999/xhtml'/>"/>
		<iframe type="content" id="xhtml5" src="data:text/xml,<html xmlns='http://www.w3.org/1999/xhtml'><head/></html>"/>
		<iframe type="content" id="xhtml6" src="data:text/xml,<html xmlns='http://www.w3.org/1999/xhtml'><head><style/></head></html>"/>
		<iframe type="content" id="xul1" src="data:application/vnd.mozilla.xul+xml,<window xmlns='http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul' title='Test'/>"/>
		<iframe type="content" id="xul2" src="data:application/vnd.mozilla.xul+xml,<window xmlns='http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul' title='Test'/>"/>
		<iframe type="content" id="svg1" src="data:text/xml,<svg xmlns='http://www.w3.org/2000/svg'><title id='t'>Test</title></svg>"/>
		<iframe type="content" id="svg2" src="data:text/xml,<svg xmlns='http://www.w3.org/2000/svg'><title id='t'>Test</title></svg>"/>

		<script type="application/javascript">
		<![CDATA[
		var imports = [ "SimpleTest", "is", "isnot", "ok" ];
		for each (var import in imports) {
		window[import] = window.opener.wrappedJSObject[import];
		}

		function testStatics() {
		function testStatic(id, expect, description) {
		is(document.getElementById(id).contentDocument.title, expect, description);
		}

		testStatic("html1", "Test", "HTML <title>");
		testStatic("html2", "Test", "choose the first HTML <title>");
		testStatic("html3", "", "No title");
		testStatic("xhtml1", "Test", "XHTML <title> in body");
		testStatic("xhtml2", "Test", "XHTML <title> as root element");
		testStatic("xhtml3", "Test", "XHTML <title> containing an element");
		testStatic("xul1", "Test", "XUL <window> title attribute");
		testStatic("svg1", "Test", "SVG <title>");
		}

		function testDynamics() {
		var inProgress = {};
		var inProgressDoc = {};
		var inProgressWin = {};
		function testDynamic(id, expect, description, op, checkDOM) {
		inProgress[description] = true;
		inProgressDoc[description] = true;
		inProgressWin[description] = true;
		var frame = document.getElementById(id);
		var done = false;

		function listener(ev) {
		inProgress[description] = false;
		is(frame.contentDocument.title, expect, "'title': " + description);
		is(frame.contentDocument, ev.target, "Unexpected target: " + description);
		if (typeof(checkDOM) != "undefined") {
		checkDOM(frame.contentDocument, "DOM: " + description);
		}
		}

		function listener2(ev) {
		inProgressDoc[description] = false;
		}
		function listener3(ev) {
		inProgressWin[description] = false;
		}
		frame.addEventListener("DOMTitleChanged", listener, false);
		frame.contentDocument.addEventListener("DOMTitleChanged", listener2, false);
		frame.contentWindow.addEventListener("DOMTitleChanged", listener3, false);

		op(frame.contentDocument);
		}

		testDynamic("html1", "Hello", "Setting HTML <title> text contents",
		function(doc){
		var t = doc.getElementById("t"); t.textContent = "Hello";
		});
		testDynamic("html2", "Foo", "Removing HTML <title>",
		function(doc){
		var t = doc.getElementById("t"); t.parentNode.removeChild(t);
		});
		testDynamic("html3", "Hello", "Appending HTML <title> element to root element",
		function(doc){
		var t = doc.createElement("title"); t.textContent = "Hello"; doc.documentElement.appendChild(t);
		});

		testDynamic("xhtml3", "Hello", "Setting 'title' clears existing <title> contents",
		function(doc){
		doc.title = "Hello";
		},
		function(doc, desc) {
		is(doc.documentElement.firstChild.data, "Hello", desc);
		is(doc.documentElement.firstChild.nextSibling, null, desc);
		});
		// This one does nothing and won't fire an event
		document.getElementById("xhtml4").contentDocument.title = "Hello";
		is(document.getElementById("xhtml4").contentDocument.title, "", "Setting 'title' does nothing with no <head>");
		testDynamic("xhtml5", "Hello", "Setting 'title' works with a <head>",
		function(doc){
		doc.title = "Hello";
		},
		function(doc, desc) {
		var head = doc.documentElement.firstChild;
		var title = head.firstChild;
		is(title.tagName.toLowerCase(), "title", desc);
		is(title.firstChild.data, "Hello", desc);
		is(title.firstChild.nextSibling, null, desc);
		is(title.nextSibling, null, desc);
		});
		testDynamic("xhtml6", "Hello", "Setting 'title' appends to <head>",
		function(doc){
		doc.title = "Hello";
		},
		function(doc, desc) {
		var head = doc.documentElement.firstChild;
		is(head.firstChild.tagName.toLowerCase(), "style", desc);
		var title = head.firstChild.nextSibling;
		is(title.tagName.toLowerCase(), "title", desc);
		is(title.firstChild.data, "Hello", desc);
		is(title.firstChild.nextSibling, null, desc);
		is(title.nextSibling, null, desc);
		});

		testDynamic("xul1", "Hello", "Setting XUL <window> title attribute",
		function(doc){
		doc.documentElement.setAttribute("title", "Hello");
		});
		testDynamic("xul2", "Hello", "Setting 'title' in XUL",
		function(doc){
		doc.title = "Hello";
		},
		function(doc, desc) {
		is(doc.documentElement.getAttribute("title"), "Hello", desc);
		is(doc.documentElement.firstChild, null, desc);
		});

		testDynamic("svg1", "Hello", "Setting SVG <title> text contents",
		function(doc){
		var t = doc.getElementById("t"); t.textContent = "Hello";
		});
		testDynamic("svg2", "", "Removing SVG <title>",
		function(doc){
		var t = doc.getElementById("t"); t.parentNode.removeChild(t);
		});

		function end() {
		for (description in inProgress) {
		ok(!inProgress[description],
		description + ": DOMTitleChange not fired");
		}
		for (description in inProgressDoc) {
		ok(inProgressDoc[description],
		description + ": DOMTitleChange fired on content document");
		}
		for (description in inProgressWin) {
		ok(inProgressWin[description],
		description + ": DOMTitleChange fired on content window");
		}

		// Closing the window will nuke the global properties, since this
		// function is not really running on this window... or something
		// like that. Thanks, executeSoon!
		var tester = SimpleTest;
		window.close();
		tester.finish();
		}
		SimpleTest.executeSoon(end);
		}

		function runTests() {
		testStatics();
		testDynamics();
		}
		]]>
		</script>
		</window>

content/base/test/test_title.html

+2 −92

Original line number	Diff line number	Diff line
		@@ -33,7 +33,7 @@
		<script>
		SimpleTest.waitForExplicitFinish();

		function testStatics() {
		function runTests() {
		function testStatic(id, expect, description) {
		is(document.getElementById(id).contentDocument.title, expect, description);
		}
		@@ -46,99 +46,9 @@ function testStatics() {
		testStatic("xhtml3", "Test", "XHTML <title> containing an element");
		testStatic("xul1", "Test", "XUL <window> title attribute");
		testStatic("svg1", "Test", "SVG <title>");
		}

		function testDynamics() {
		var inProgress = {};
		function testDynamic(id, expect, description, op, checkDOM) {
		inProgress[description] = true;
		var frame = document.getElementById(id);
		var done = false;

		function listener() {
		inProgress[description] = false;
		is(frame.contentDocument.title, expect, "'title': " + description);
		if (typeof(checkDOM) != undefined) {
		checkDOM(frame.contentDocument, "DOM: " + description);
		}
		}
		frame.contentDocument.addEventListener("DOMTitleChanged", listener, false);

		op(frame.contentDocument);
		}

		testDynamic("html1", "Hello", "Setting HTML <title> text contents", function(doc){
		var t = doc.getElementById("t"); t.textContent = "Hello";
		});
		testDynamic("html2", "Foo", "Removing HTML <title>", function(doc){
		var t = doc.getElementById("t"); t.parentNode.removeChild(t);
		});
		testDynamic("html3", "Hello", "Appending HTML <title> element to root element", function(doc){
		var t = doc.createElement("title"); t.textContent = "Hello"; doc.documentElement.appendChild(t);
		});

		testDynamic("xhtml3", "Hello", "Setting 'title' clears existing <title> contents", function(doc){
		doc.title = "Hello";
		}, function(doc, desc) {
		is(doc.documentElement.firstChild.data, "Hello", desc);
		is(doc.documentElement.firstChild.nextSibling, null, desc);
		});
		// This one does nothing and won't fire an event
		document.getElementById("xhtml4").contentDocument.title = "Hello";
		is(document.getElementById("xhtml4").contentDocument.title, "", "Setting 'title' does nothing with no <head>");
		testDynamic("xhtml5", "Hello", "Setting 'title' works with a <head>", function(doc){
		doc.title = "Hello";
		}, function(doc, desc) {
		var head = doc.documentElement.firstChild;
		var title = head.firstChild;
		is(title.tagName.toLowerCase(), "title", desc);
		is(title.firstChild.data, "Hello", desc);
		is(title.firstChild.nextSibling, null, desc);
		is(title.nextSibling, null, desc);
		});
		testDynamic("xhtml6", "Hello", "Setting 'title' appends to <head>", function(doc){
		doc.title = "Hello";
		}, function(doc, desc) {
		var head = doc.documentElement.firstChild;
		is(head.firstChild.tagName.toLowerCase(), "style", desc);
		var title = head.firstChild.nextSibling;
		is(title.tagName.toLowerCase(), "title", desc);
		is(title.firstChild.data, "Hello", desc);
		is(title.firstChild.nextSibling, null, desc);
		is(title.nextSibling, null, desc);
		});

		testDynamic("xul1", "Hello", "Setting XUL <window> title attribute", function(doc){
		doc.documentElement.setAttribute("title", "Hello");
		});
		testDynamic("xul2", "Hello", "Setting 'title' in XUL", function(doc){
		doc.title = "Hello";
		}, function(doc, desc) {
		is(doc.documentElement.getAttribute("title"), "Hello", desc);
		is(doc.documentElement.firstChild, null, desc);
		});

		testDynamic("svg1", "Hello", "Setting SVG <title> text contents", function(doc){
		var t = doc.getElementById("t"); t.textContent = "Hello";
		});
		testDynamic("svg2", "", "Removing SVG <title>", function(doc){
		var t = doc.getElementById("t"); t.parentNode.removeChild(t);
		});

		function end() {
		for (description in inProgress) {
		ok(!inProgress[description], description + ": DOMTitleChange not fired");
		}
		SimpleTest.finish();
		}
		setTimeout(end, 500);
		}

		function runTests() {
		testStatics();
		testDynamics();
		}

		</script>
		</pre>
		</body>