Commit 075323ed authored by Robert O'Callahan's avatar Robert O'Callahan
Browse files

Bug 505912. Trust the widget visibility in UpdateWidgetArea. r=dbaron 

--HG--
extra : rebase_source : 4c6e1b2366b430763cce546ab0e26576705a0ca3
parent 4844e8ad

layout/generic/crashtests/505912-1.html

0 → 100644
+6 −0
Original line number Diff line number Diff line 
<!DOCTYPE HTML>

<html>

<body onload="document.getElementById('x').style.visibility = 'hidden';">

<embed id="x" type="application/x-test" wmode="window"></embed>

</body>

</html>

layout/generic/crashtests/crashtests.list

+1 −0
Original line number Diff line number Diff line
@@ -235,3 +235,4 @@ load 479938-1.html 
load 480345-1.html

load 494332-1.html

load 501535-1.html

load 505912-1.html

view/src/nsViewManager.cpp

+5 −9
Original line number Diff line number Diff line
@@ -738,14 +738,10 @@ nsViewManager::UpdateWidgetArea(nsView *aWidgetView, nsIWidget* aWidget, 
  }



  // If the widget is hidden, it don't cover nothing

  if (nsViewVisibility_kHide == aWidgetView->GetVisibility()) {

#ifdef DEBUG

  if (aWidget) {

    PRBool visible;

    aWidget->IsVisible(visible);

      NS_ASSERTION(!visible, "View is hidden but widget is visible!");

    }

#endif

    if (!visible)

      return;

  }