Commit 2412e0e4 authored by Nick Mathewson's avatar Nick Mathewson 🦀
Browse files

Check return of init_keys() ip_address_changed: fix Coverity CID 484

parent 103c861d

changes/cov484

0 → 100644
+4 −0
Original line number Diff line number Diff line 
  o Minor bugfixes:

    - Report any failure in init_keys() calls done because our IP address

      has changed. Spotted by Coverity Scan. Bugfix on 0.1.1.4-alpha;

      fixes CID 484.

src/or/main.c

+2 −1
Original line number Diff line number Diff line
@@ -1378,7 +1378,8 @@ ip_address_changed(int at_interface) 
  if (at_interface) {

    if (! server) {

      /* Okay, change our keys. */

      init_keys();

      if (init_keys()<0)

        log_warn(LD_GENERAL, "Unable to rotate keys after IP change!");

    }

  } else {

    if (server) {