Commit 2491fff5 authored by Nick Mathewson's avatar Nick Mathewson 🥔
Browse files

Triage the XXX023 and XXX022 comments: postpone many.

parent 8030ec4f

src/common/address.c

+1 −1
Original line number Diff line number Diff line
@@ -1363,7 +1363,7 @@ get_interface_address6(int severity, sa_family_t family, tor_addr_t *addr) 


/* ======

 * IPv4 helpers

 * XXXX023 IPv6 deprecate some of these.

 * XXXX024 IPv6 deprecate some of these.

 */



/** Return true iff <b>ip</b> (in host order) is an IP reserved to localhost,

src/common/compat.c

+1 −1
Original line number Diff line number Diff line
@@ -15,7 +15,7 @@ 
/* This is required on rh7 to make strptime not complain.

 * We also need it to make memmem get defined (where available)

 */

/* XXXX023 We should just use AC_USE_SYSTEM_EXTENSIONS in our autoconf,

/* XXXX024 We should just  use AC_USE_SYSTEM_EXTENSIONS in our autoconf,

 * and get this (and other important stuff!) automatically. Once we do that,

 * make sure to also change the extern char **environ detection in

 * configure.in, because whether that is declared or not depends on whether

src/or/buffers.c

+3 −3
Original line number Diff line number Diff line
@@ -677,12 +677,12 @@ read_to_chunk_tls(buf_t *buf, chunk_t *chunk, tor_tls_t *tls, 
 * (because of EOF), set *<b>reached_eof</b> to 1 and return 0. Return -1 on

 * error; else return the number of bytes read.

 */

/* XXXX023 indicate "read blocked" somehow? */

/* XXXX024 indicate "read blocked" somehow? */

int

read_to_buf(tor_socket_t s, size_t at_most, buf_t *buf, int *reached_eof,

            int *socket_error)

{

  /* XXXX023 It's stupid to overload the return values for these functions:

  /* XXXX024 It's stupid to overload the return values for these functions:

   * "error status" and "number of bytes read" are not mutually exclusive.

   */

  int r = 0;
@@ -855,7 +855,7 @@ flush_chunk_tls(tor_tls_t *tls, buf_t *buf, chunk_t *chunk, 
int

flush_buf(tor_socket_t s, buf_t *buf, size_t sz, size_t *buf_flushlen)

{

  /* XXXX023 It's stupid to overload the return values for these functions:

  /* XXXX024 It's stupid to overload the return values for these functions:

   * "error status" and "number of bytes flushed" are not mutually exclusive.

   */

  int r;

src/or/circuitbuild.c

+4 −4
Original line number Diff line number Diff line
@@ -44,12 +44,12 @@ 


/********* START VARIABLES **********/

/** Global list of circuit build times */

// XXXX023: Add this as a member for entry_guard_t instead of global?

// XXXX: Add this as a member for entry_guard_t instead of global?

// Then we could do per-guard statistics, as guards are likely to

// vary in their own latency. The downside of this is that guards

// can change frequently, so we'd be building a lot more circuits

// most likely.

/* XXXX023 Make this static; add accessor functions. */

/* XXXX024 Make this static; add accessor functions. */

circuit_build_times_t circ_times;



/** A global list of all circuits at this hop. */
@@ -4238,7 +4238,7 @@ entry_guards_compute_status(const or_options_t *options, time_t now) 
 * If <b>mark_relay_status</b>, also call router_set_status() on this

 * relay.

 *

 * XXX023 change succeeded and mark_relay_status into 'int flags'.

 * XXX024 change succeeded and mark_relay_status into 'int flags'.

 */

int

entry_guard_register_connect_status(const char *digest, int succeeded,
@@ -4763,7 +4763,7 @@ entry_guards_parse_state(or_state_t *state, int set, char **msg) 
    }

    entry_guards = new_entry_guards;

    entry_guards_dirty = 0;

    /* XXX023 hand new_entry_guards to this func, and move it up a

    /* XXX024 hand new_entry_guards to this func, and move it up a

     * few lines, so we don't have to re-dirty it */

    if (remove_obsolete_entry_guards(now))

      entry_guards_dirty = 1;

src/or/circuitlist.c

+2 −2
Original line number Diff line number Diff line
@@ -1180,7 +1180,7 @@ circuit_mark_all_unused_circs(void) 
 * This is useful for letting the user change pseudonyms, so new

 * streams will not be linkable to old streams.

 */

/* XXX023 this is a bad name for what this function does */

/* XXX024 this is a bad name for what this function does */

void

circuit_expire_all_dirty_circs(void)

{
@@ -1191,7 +1191,7 @@ circuit_expire_all_dirty_circs(void) 
    if (CIRCUIT_IS_ORIGIN(circ) &&

        !circ->marked_for_close &&

        circ->timestamp_dirty)

      /* XXXX023 This is a screwed-up way to say "This is too dirty

      /* XXXX024 This is a screwed-up way to say "This is too dirty

       * for new circuits. */

      circ->timestamp_dirty -= options->MaxCircuitDirtiness;

  }