diff --git a/changes/bug14116_025 b/changes/bug14116_025 new file mode 100644 index 0000000000000000000000000000000000000000..0859f626a52df75eb53c9033757046f2034c6549 --- /dev/null +++ b/changes/bug14116_025 @@ -0,0 +1,3 @@ + o Minor bugfixes (controller): + - Avoid crashing on a malformed EXTENDCIRCUIT command. Fixes bug 14116; + bugfix on 0.2.2.9-alpha. diff --git a/src/or/control.c b/src/or/control.c index d21682a19ce26a6d7257b21c5c27c08bdef24aa4..3dbaa1bdf27d9a35f860e727b746336f5ecaf457 100644 --- a/src/or/control.c +++ b/src/or/control.c @@ -2465,6 +2465,14 @@ handle_control_extendcircuit(control_connection_t *conn, uint32_t len, goto done; } + if (smartlist_len(args) < 2) { + connection_printf_to_buf(conn, + "512 syntax error: not enough arguments.\r\n"); + SMARTLIST_FOREACH(args, char *, cp, tor_free(cp)); + smartlist_free(args); + goto done; + } + smartlist_split_string(router_nicknames, smartlist_get(args,1), ",", 0, 0); SMARTLIST_FOREACH(args, char *, cp, tor_free(cp));