From 5986589b48de6addf99436df1feeea1362767acb Mon Sep 17 00:00:00 2001
From: rl1987 <rl1987@sdf.lonestar.org>
Date: Mon, 12 Feb 2018 21:08:17 +0100
Subject: [PATCH] Call strlen() once
---
src/common/util.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/common/util.c b/src/common/util.c
index ea0ec3daee..d8891c6a53 100644
--- a/src/common/util.c
+++ b/src/common/util.c
@@ -1081,12 +1081,13 @@ string_is_valid_dest(const char *string)
{
char *tmp = NULL;
int retval;
+ size_t len = strlen(string);
tor_assert(string);
- tor_assert(strlen(string) > 0);
+ tor_assert(len > 0);
- if (string[0] == '[' && string[strlen(string) - 1] == ']')
- string = tmp = tor_strndup(string + 1, strlen(string) - 2);
+ if (string[0] == '[' && string[len - 1] == ']')
+ string = tmp = tor_strndup(string + 1, len - 2);
retval = string_is_valid_ipv4_address(string) ||
string_is_valid_ipv6_address(string) ||
--
GitLab