From 7dbf2511c39e47db609c77e255dc1a186b8e1ff1 Mon Sep 17 00:00:00 2001
From: Roger Dingledine <arma@torproject.org>
Date: Thu, 17 Nov 2005 21:45:38 +0000
Subject: [PATCH] when you type 'getinfo' with no arguments, it doesn't give
you any answer at all. this is clearly a bug.
the more interesting bug is whether things like setconf, getconf,
and so on should return 250 OK if you give them no arguments. should
we have a new "you didn't ask me anything" response code, or just
leave it as is?
svn:r5412
---
src/or/control.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/or/control.c b/src/or/control.c
index cb97f5b261..8efb3cc69b 100644
--- a/src/or/control.c
+++ b/src/or/control.c
@@ -1452,7 +1452,7 @@ handle_control_getinfo(connection_t *conn, uint32_t len, const char *body)
tor_assert(msg_len > 0); /* it will at least be terminated */
send_control0_message(conn, CONTROL0_CMD_INFOVALUE,
msg_len, msg);
- } else if (smartlist_len(answers)) {
+ } else {
int i;
for (i = 0; i < smartlist_len(answers); i += 2) {
char *k = smartlist_get(answers, i);
--
GitLab