Commit 8df6a65e authored by rl1987's avatar rl1987
Browse files

Fix shellcheck warning in zero_length_keys.sh

parent bfd1d702

changes/ticket29068

0 → 100644
+2 −0
Original line number Diff line number Diff line 
  o Code simplification and refactoring (shell scripts):

    - Fix shellcheck warnings in zero_length_keys.sh. Resolves issue 29068.

src/test/zero_length_keys.sh

+3 −3
Original line number Diff line number Diff line
@@ -19,7 +19,7 @@ 
#   3: a command failed - the test could not be completed

#



if [ $# -eq 0 ] || [ ! -f ${1} ] || [ ! -x ${1} ]; then

if [ $# -eq 0 ] || [ ! -f "${1}" ] || [ ! -x "${1}" ]; then

  echo "Usage: ${0} PATH_TO_TOR [-z|-d|-e]"

  exit 1

elif [ $# -eq 1 ]; then
@@ -31,7 +31,7 @@ else #[$# -gt 1 ]; then 
  shift

fi



DATA_DIR=`mktemp -d -t tor_zero_length_keys.XXXXXX`

DATA_DIR=$(mktemp -d -t tor_zero_length_keys.XXXXXX)

if [ -z "$DATA_DIR" ]; then

  echo "Failure: mktemp invocation returned empty string" >&2

  exit 3
@@ -40,7 +40,7 @@ if [ ! -d "$DATA_DIR" ]; then 
  echo "Failure: mktemp invocation result doesn't point to directory" >&2

  exit 3

fi

trap "rm -rf '$DATA_DIR'" 0

trap 'rm -rf "$DATA_DIR"' 0



touch "$DATA_DIR"/empty_torrc