Commit b7566d46 authored by Nick Mathewson's avatar Nick Mathewson 🦀
Browse files

Fix a signed integer overflow in dir/download_status_random_backoff 

Fix for 22924. Bugfix on 0.2.9.1-alpha when the test was introducd
-- though it couldn't actually overflow until we fixed 17750.

Additionally, this only seems to overflow on 32-bit, and only when
the compiler doesn't re-order the (possibly dead) assignment out of
the way.  We ran into it on a 32-bit ubuntu trusty builder.
parent 527c0735

changes/bug22924

0 → 100644
+4 −0
Original line number Diff line number Diff line 
  o Minor bugfies (tests):

    - Fix a signed-integer overflow in the unit tests for

      dir/download_status_random_backoff, which was untriggered until we

      fixed bug 17750.  Fixes bug 22924; bugfix on 0.2.9.1-alpha.

src/test/test_dir.c

+3 −1
Original line number Diff line number Diff line
@@ -3657,12 +3657,14 @@ download_status_random_backoff_helper(int min_delay, int max_delay) 
    }



    /* Advance */

    current_time += increment;

    ++(dls_random.n_download_attempts);

    ++(dls_random.n_download_failures);



    /* Try another maybe */

    old_increment = increment;

    if (increment >= max_delay)

      current_time += increment;



  } while (increment < max_delay);



 done: