Commit d5c83f20 authored by Sebastian Hahn's avatar Sebastian Hahn
Browse files

Remove unused function declarations 

Also remove some #if 0'd code from the unit tests for buffers. The
code was killed in e6794e58 (5 years
ago), and is now broken anyways.
parent 5ffe1055

changes/headercleanup

0 → 100644
+3 −0
Original line number Diff line number Diff line 
  o Code simplifications and refactoring:

    - Remove a bunch of unused function declarations as well as a block of

      #if 0'd code from the unit tests. Closes bug 1824.

src/or/buffers.h

+0 −1
Original line number Diff line number Diff line
@@ -23,7 +23,6 @@ void buf_dump_freelist_sizes(int severity); 
size_t buf_datalen(const buf_t *buf);

size_t buf_allocation(const buf_t *buf);

size_t buf_slack(const buf_t *buf);

const char *_buf_peek_raw_buffer(const buf_t *buf);



int read_to_buf(int s, size_t at_most, buf_t *buf, int *reached_eof,

                int *socket_error);

src/or/circuitbuild.h

+0 −2
Original line number Diff line number Diff line
@@ -107,8 +107,6 @@ void circuit_build_times_initial_alpha(circuit_build_times_t *cbt, 
                                       double quantile, double time_ms);

int circuit_build_times_update_alpha(circuit_build_times_t *cbt);

double circuit_build_times_cdf(circuit_build_times_t *cbt, double x);

void circuit_build_times_add_timeout_worker(circuit_build_times_t *cbt,

                                       double quantile_cutoff);

void circuitbuild_running_unit_tests(void);

void circuit_build_times_reset(circuit_build_times_t *cbt);

src/or/connection_edge.h

+0 −1
Original line number Diff line number Diff line
@@ -82,7 +82,6 @@ void addressmap_get_mappings(smartlist_t *sl, time_t min_expires, 
int connection_ap_handshake_rewrite_and_attach(edge_connection_t *conn,

                                               origin_circuit_t *circ,

                                               crypt_path_t *cpath);

int hostname_is_noconnect_address(const char *address);



/** Possible return values for parse_extended_hostname. */

typedef enum hostname_type_t {

src/or/connection_or.h

+0 −4
Original line number Diff line number Diff line
@@ -46,10 +46,6 @@ void connection_or_write_var_cell_to_buf(const var_cell_t *cell, 
int connection_or_send_destroy(circid_t circ_id, or_connection_t *conn,

                               int reason);

int connection_or_send_netinfo(or_connection_t *conn);

int connection_or_send_cert(or_connection_t *conn);

int connection_or_send_link_auth(or_connection_t *conn);

int connection_or_compute_link_auth_hmac(or_connection_t *conn,

                                         char *hmac_out);

int is_or_protocol_version_known(uint16_t version);



void cell_pack(packed_cell_t *dest, const cell_t *src);