Commit e6a05c1c authored by Nick Mathewson's avatar Nick Mathewson 🥔
Browse files

Add a missing goto to an unusable branch and make the branch LD_BUG. 

(It's LD_BUG to reach this point because the hashed password values
were tested earlier from options_validate)

[Coverity CID 1232091]
parent 2a0a5fe6

src/or/control.c

+2 −1
Original line number Diff line number Diff line
@@ -1160,9 +1160,10 @@ handle_control_authenticate(control_connection_t *conn, uint32_t len, 
    }

    if (bad) {

      if (!also_cookie) {

        log_warn(LD_CONTROL,

        log_warn(LD_BUG,

                 "Couldn't decode HashedControlPassword: invalid base16");

        errstr="Couldn't decode HashedControlPassword value in configuration.";

        goto err;

      }

      bad_password = 1;

      SMARTLIST_FOREACH(sl, char *, cp, tor_free(cp));