Commit f0f3bbc6 authored by Nick Mathewson's avatar Nick Mathewson 🤹
Browse files

r8901@Kushana: nickm | 2006-09-21 20:43:48 -0400 

 I tracked a bug in server-side reverse DNS to something concerning the caching code. Ive disabled server-side cacheing for reverse DNS answers for now, and I am noting the bug in the TODO.


svn:r8454
parent 78f981db

doc/TODO

+1 −0
Original line number Diff line number Diff line
@@ -109,6 +109,7 @@ d - Special-case localhost? 
      o Connect to resolve cells, server-side.

      o Add element to routerinfo to note routers that aren't using eventdns,

        so we can avoid sending them reverse DNS etc.

      - Fix the bug with server-side caching, whatever is causing it.

      . Add client-side interface

        o SOCKS interface: specify

        o SOCKS interface: implement

src/or/dns.c

+5 −0
Original line number Diff line number Diff line
@@ -814,6 +814,11 @@ add_answer_to_cache(const char *address, int is_reverse, uint32_t addr, 
  if (outcome == DNS_RESOLVE_FAILED_TRANSIENT)

    return;



  /* XXX This is dumb, but it seems to workaround a bug I can't find.  We

   * should nail this so we can cache reverse DNS answers. -NM */

  if (is_reverse)

    return;



  //log_notice(LD_EXIT, "Adding to cache: %s -> %s (%lx, %s), %d",

  //           address, is_reverse?"(reverse)":"", (unsigned long)addr,

  //           hostname?hostname:"NULL",(int)outcome);