Commit ffe22fab authored by Nick Mathewson's avatar Nick Mathewson 🥔
Browse files

Indeed, arma was right. There was one ntohl too many in debug_ntop in eventdns.c 

svn:r17826
parent c190842a

ChangeLog

+1 −0
Original line number Diff line number Diff line
@@ -25,6 +25,7 @@ Changes in version 0.2.1.10-alpha - 2009-01-?? 
      it easier to cannibalize circuits like this later.

    - Authorities now list vote for the Stable flag for any router whose

      weighted MTBF is at least 5 days, regardless of the mean MTBF.

    - Stop logging nameserver addresses in reverse order.



  o Code simplifications and refactoring:

    - Change our header file guard macros to be less likely to conflict

src/or/eventdns.c

+1 −3
Original line number Diff line number Diff line
@@ -402,9 +402,7 @@ debug_ntop(const struct sockaddr *sa) 
{

	if (sa->sa_family == AF_INET) {

		struct sockaddr_in *sin = (struct sockaddr_in *) sa;

		return debug_ntoa(ntohl(sin->sin_addr.s_addr));

		/* XXX021 Nick: the above does ntoa of ntohl. This is

		 * probably one to-host too many. -RD */

		return debug_ntoa(sin->sin_addr.s_addr);

	}

	if (sa->sa_family == AF_INET6) {

		/* Tor-specific.  In libevent, add more check code. */