1. 12 Jan, 2021 8 commits
  2. 11 Jan, 2021 12 commits
  3. 21 Dec, 2020 7 commits
    • David Goulet's avatar
    • David Goulet's avatar
      relay: Log address suggested by directory authorities · aae9a05a
      David Goulet authored
      If we get an address suggestion from a directory authority and we have no
      address configured or discovered, log it at notice level so the operator can
      learn what address will be used by Tor.
      Fixes #40201
      Signed-off-by: David Goulet's avatarDavid Goulet <dgoulet@torproject.org>
    • Nick Mathewson's avatar
    • Nick Mathewson's avatar
    • David Goulet's avatar
      test: Fix memleak in test/load_stats_file · f4cbcde2
      David Goulet authored and Nick Mathewson's avatar Nick Mathewson committed
      Signed-off-by: David Goulet's avatarDavid Goulet <dgoulet@torproject.org>
    • Karsten Loesing's avatar
      Fix timestamp parser in new load_stats_file. · 5dd6304f
      Karsten Loesing authored and Nick Mathewson's avatar Nick Mathewson committed
      The previous parser only considered stats files _starting_ with the
      timestamp tag, not stats files having the timestamp tag in a later
      position. While this applies to all current stats files, a future
      stats file might look differently. Better to fix the function now than
      be surprised in another 9 years from now.
      This commit also adds a test case for such future stats, and it fixes
      stats file paths in newly added unit tests.
    • David Goulet's avatar
      relay: Report the entire content of a stats file · c934fced
      David Goulet authored and Nick Mathewson's avatar Nick Mathewson committed
      It turns out that 9 years ago, we stopped appending data into stats file and
      rather overwrite everytime we have new stats (see commit
      The load_stats_file() function was still thinking that we could have the same
      line many times in the file which turns out to be false since 9 years ago.
      However, that did not cause problem until IPv6 connection stats came along
      which introduced a new line in conn-stats: "ipv6-conn-bi-direct ...".
      Before, that file contained a single line starting with the tag
      "conn-bi-direct".  That very tag appears also in the IPv6 tag (see above) so
      the load_stats_file() function would consider that the IPv6 line as the last
      tag to be appeneded to the file and fail to report the line above (for IPv4).
      It would actually truncate the IPv6 line and report it (removing the "ipv6-"
      In other words, "conn-bi-direct" was not reported and instead
      "ipv6-conn-bi-direct" was used without the "ipv6-" part.
      This commit refactors the entire function so that now it looks for a
      "timestamp tag" to validate and then if everything is fine, returns the entire
      content of the file. The refactor simplifies the function, adds logging in
      case of failures and modernize it in terms of coding standard.
      Unit tests are also added that makes sure the loaded content matches the
      entire file if timestamp validation passes.
      Fixes #40226
      Signed-off-by: David Goulet's avatarDavid Goulet <dgoulet@torproject.org>
  4. 17 Dec, 2020 3 commits
  5. 16 Dec, 2020 7 commits
  6. 15 Dec, 2020 3 commits