gettor merge requestshttps://gitlab.torproject.org/tpo/anti-censorship/gettor-project/gettor/-/merge_requests2021-10-25T17:45:21Zhttps://gitlab.torproject.org/tpo/anti-censorship/gettor-project/gettor/-/merge_requests/18Write the right gitlab link2021-10-25T17:45:21Zmeskiomeskio@torproject.orgWrite the right gitlab linkThe version string on the repo uses '.', we don't need to rewrite them
by '-'.
Closes: #82The version string on the repo uses '.', we don't need to rewrite them
by '-'.
Closes: #82https://gitlab.torproject.org/tpo/anti-censorship/gettor-project/gettor/-/merge_requests/17Make one script for automatic updates2021-08-27T16:19:03ZHackerNCoderhackerncoder@encryptionin.spaceMake one script for automatic updateshttps://gitlab.torproject.org/tpo/anti-censorship/gettor-project/gettor/-/merge_requests/15Only parse email subject and body2021-01-12T19:01:08ZCecylia BocovichOnly parse email subject and bodyCloses issue #75 where the headers were being parsed for locale
instead of the message body.Closes issue #75 where the headers were being parsed for locale
instead of the message body.https://gitlab.torproject.org/tpo/anti-censorship/gettor-project/gettor/-/merge_requests/13Don't assume that request has "command" key.2020-06-13T10:49:38ZPhilipp Winterphw@torproject.orgDon't assume that request has "command" key.If GetTor deals with an autoresponder, it returns an empty request,
which is then passed to parse_callback, which raises a KeyError because
of request["command"]:
2020-05-29 19:04:43+0000 [email parser] Error while parsing email content...If GetTor deals with an autoresponder, it returns an empty request,
which is then passed to parse_callback, which raises a KeyError because
of request["command"]:
2020-05-29 19:04:43+0000 [email parser] Error while parsing email content: [Failure instance: Traceback: <class 'KeyError'>: 'command'
/usr/lib/python3/dist-packages/twisted/internet/defer.py:311:addCallbacks
/usr/lib/python3/dist-packages/twisted/internet/defer.py:654:_runCallbacks
/usr/lib/python3/dist-packages/twisted/internet/defer.py:1613:unwindGenerator
/usr/lib/python3/dist-packages/twisted/internet/defer.py:1529:_cancellableInlineCallbacks
--- <exception caught here> ---
/usr/lib/python3/dist-packages/twisted/internet/defer.py:1418:_inlineCallbacks
/srv/gettor.torproject.org/home/gettor/gettor/parse/email.py:256:parse_callback
].
This is a fixup of: <https://bugs.torproject.org/34286>https://gitlab.torproject.org/tpo/anti-censorship/gettor-project/gettor/-/merge_requests/11Check to see if email is from an autoresponder2020-05-29T19:02:16ZCecylia BocovichCheck to see if email is from an autoresponderThis checks to see if an incoming request is from a known autoresponder.
GetTor can get into infinite loops with itself or postmaster addresses
(Bug #34286)This checks to see if an incoming request is from a known autoresponder.
GetTor can get into infinite loops with itself or postmaster addresses
(Bug #34286)https://gitlab.torproject.org/tpo/anti-censorship/gettor-project/gettor/-/merge_requests/10Ignore emails from Mail Delivery System2020-05-23T14:20:37ZCecylia BocovichIgnore emails from Mail Delivery SystemThis ignores emails with the username "MAILER-DAEMON", a common email
for mail delivery systems. The goal of this is to avoid getting into a
loop with mail delivery system autoresponders after a bounced email.This ignores emails with the username "MAILER-DAEMON", a common email
for mail delivery systems. The goal of this is to avoid getting into a
loop with mail delivery system autoresponders after a bounced email.https://gitlab.torproject.org/tpo/anti-censorship/gettor-project/gettor/-/merge_requests/8Delete service instance during shutdown2020-05-04T19:07:50ZCecylia BocovichDelete service instance during shutdownBefore we were calling a non-existent shutdown function. These instances
already have __del__ functions so we can just call those instead.Before we were calling a non-existent shutdown function. These instances
already have __del__ functions so we can just call those instead.https://gitlab.torproject.org/tpo/anti-censorship/gettor-project/gettor/-/merge_requests/6Refactor to dry out sendmail2020-04-29T15:23:37ZCecylia BocovichRefactor to dry out sendmailInstead of processing link and help requests separately, we can process
them together and use the command to determine the different subject and
body messages.
Removed unused code and simplified database command.Instead of processing link and help requests separately, we can process
them together and use the command to determine the different subject and
body messages.
Removed unused code and simplified database command.https://gitlab.torproject.org/tpo/anti-censorship/gettor-project/gettor/-/merge_requests/5Check SMTP error code and remove request from db2020-04-27T21:52:08ZCecylia BocovichCheck SMTP error code and remove request from dbThis adds an extra check on SMTP errors to see if it's due to a bad
recipient address and then removes the request from the database. This
prevents one bad request from hanging up the processing of other
requests (see https://bugs.torpro...This adds an extra check on SMTP errors to see if it's due to a bad
recipient address and then removes the request from the database. This
prevents one bad request from hanging up the processing of other
requests (see https://bugs.torproject.org/34027).https://gitlab.torproject.org/tpo/anti-censorship/gettor-project/gettor/-/merge_requests/4Ticket/329122020-04-22T19:43:49ZCecylia BocovichTicket/32912This removes a lot of old and unused code.
See https://trac.torproject.org/projects/tor/ticket/32912This removes a lot of old and unused code.
See https://trac.torproject.org/projects/tor/ticket/32912https://gitlab.torproject.org/tpo/anti-censorship/gettor-project/gettor/-/merge_requests/3Ticket/232262020-03-30T17:59:37ZCecylia BocovichTicket/23226https://gitlab.torproject.org/tpo/anti-censorship/gettor-project/gettor/-/merge_requests/2Always reply to gettor emails2020-03-06T19:17:34ZCecylia BocovichAlways reply to gettor emailsThis fixes a bug where improperly formatted emails were not receiving
gettor replies. We should always reply to emails and default to sending
a help message if the request was invalid.
This also prioritizes sending links if both a valid...This fixes a bug where improperly formatted emails were not receiving
gettor replies. We should always reply to emails and default to sending
a help message if the request was invalid.
This also prioritizes sending links if both a valid links request and
the word help were sent. Several tests were added.HiroHirohttps://gitlab.torproject.org/tpo/anti-censorship/gettor-project/gettor/-/merge_requests/1Fix/313132019-08-26T15:36:59ZPhilipp Winterphw@torproject.orgFix/31313HiroHiro