These commits were only meant to be in the main branch in the old gitweb
location. There presence here in the new location was an error.

This reverts commit 0630d8d2.
This reverts commit c4847124.

Closes: #1

This reverts commit 24b2b145.

tpo/anti-censorship/team#86 (comment 2823122)

These might have been done in b31bdca7,
apart from the https://spec.torproject.org/ext-orport-spec permalink
which did not exist at that time.

The intention of this is to permit setting a source address to avoid
ephemeral port exhaustion on servers with many connections.

https://bugs.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/40198#note_2839304
https://bugs.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/40201#note_2839433

It had hardcoded the same value as was passed in, so there is no change
in behavior.

Proposals 196 (ExtORPort) and 217 (ExtORPort authentication) were merged
together into ext-orport-spec.txt in
tpo/core/torspec#50.

Proposal 232 (TOR_PT_PROXY) became part of pt-spec.txt in
https://gitweb.torproject.org/torspec.git/commit/pt-spec.txt?id=4dcd7e94f17c072e771119ec90d7cbce4a4788a4.

This is an attempt to fix a warning message observed when trying to
build the Snowflake proxy.
https://bugs.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/40065

https://bugs.torproject.org/15826#comment:1

https://bugs.torproject.org/15826

The requirement to wait until handlers are finished, as well as the
complicated signal counting logic, was removed from pt-spec.txt in 2014.

https://bugs.torproject.org/26389#comment:5

The loop logic assumed that there was at least one handler running when
a signal was received; if there were none, it would wait forever for a
handler event to happen.

Cf. https://bugs.torproject.org/24875

pt-spec.txt 0ef45b97b1a935489335fc31d625c463b076c1e3
196-transport-control-ports.txt f59e8f5b2819842fe6cb5b162a9226a4f1891b4d

It would always panic with a the message
	keyword "PROXY-ERROR %s\n" contains forbidden bytes

The ProxyError test currently panics because of a bug in ProxyError.

--- FAIL: TestErrors (0.00s)
panic: keyword "PROXY-ERROR %s\n" contains forbidden bytes [recovered]
        panic: keyword "PROXY-ERROR %s\n" contains forbidden bytes