Snowflake issueshttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues2020-06-30T16:04:59Zhttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34146localize screenshots on snowflake page2020-06-30T16:04:59ZRoger Dingledinelocalize screenshots on snowflake pagehttps://snowflake.torproject.org/?lang=zh_CN
scroll down to the picture of Tor Browser's network settings. That's an English Tor Browser. Should the Chinese version of the page be showing people using a Tor Browser in Chinese?https://snowflake.torproject.org/?lang=zh_CN
scroll down to the picture of Tor Browser's network settings. That's an English Tor Browser. Should the Chinese version of the page be showing people using a Tor Browser in Chinese?https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34140Require semicolons2020-06-27T13:40:09ZArlo BreaultRequire semicolonshttps://eslint.org/docs/rules/semi
From https://github.com/arlolra/snowflake-webext/commit/d0fc6aa10cc6a8cc85b9037d780e53282ae83bea#r38995051https://eslint.org/docs/rules/semi
From https://github.com/arlolra/snowflake-webext/commit/d0fc6aa10cc6a8cc85b9037d780e53282ae83bea#r38995051https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34132Fix running an npm globally installed snowflake2020-06-27T13:40:10ZArlo BreaultFix running an npm globally installed snowflakeSnowflake is now an [npm published package](https://www.npmjs.com/package/snowflake-pt) that can install a global bin with `npm i -g`
It seems to be missing a `#!/usr/bin/env node` at the top of the script thoughSnowflake is now an [npm published package](https://www.npmjs.com/package/snowflake-pt) that can install a global bin with `npm i -g`
It seems to be missing a `#!/usr/bin/env node` at the top of the script thoughhttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34128The badge should have a version number discoverable in the source2020-06-27T13:40:10ZArlo BreaultThe badge should have a version number discoverable in the sourceIt's not clear if https://snowflake.torproject.org/embed.html is running `0.3.0`
Was it published after the most recent release?It's not clear if https://snowflake.torproject.org/embed.html is running `0.3.0`
Was it published after the most recent release?https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34127npm publish as part of the release process2020-06-27T13:40:10ZArlo Breaultnpm publish as part of the release processConsider `npm publish`ing when a new release is made.
The patch here makes updating the package.json part of the release process,
https://github.com/arlolra/snowflake-webext/commit/7231928c56ad509419c20ed1bb9be5645373c86cConsider `npm publish`ing when a new release is made.
The patch here makes updating the package.json part of the release process,
https://github.com/arlolra/snowflake-webext/commit/7231928c56ad509419c20ed1bb9be5645373c86chttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34126Handle onicecandidate firing after connection closed2020-06-27T13:40:10ZArlo BreaultHandle onicecandidate firing after connection closedThis may just be an issue with node-webrtc, but `Broker.sendAnswer` fires when waiting on an offer times out.
https://github.com/arlolra/snowflake-webext/commit/529a789bfcb9539176288f6659e7f2a60c2d6271This may just be an issue with node-webrtc, but `Broker.sendAnswer` fires when waiting on an offer times out.
https://github.com/arlolra/snowflake-webext/commit/529a789bfcb9539176288f6659e7f2a60c2d6271https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34124snowflake funktioniert nicht2020-06-27T13:40:10Zcypherpunkssnowflake funktioniert nichtAnzeige: WebRTC-Fähigkeit nicht erkannt.
Was soll ich tun?Anzeige: WebRTC-Fähigkeit nicht erkannt.
Was soll ich tun?https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34092Snowflake no longer working on Google Chrome2020-06-30T15:49:08ZcypherpunksSnowflake no longer working on Google ChromeExtension icon disappeared and cannot enable Snowflake in Google Chrome.Extension icon disappeared and cannot enable Snowflake in Google Chrome.https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34053Update version of wrtc packate for web proxies2020-06-27T13:40:11ZCecylia BocovichUpdate version of wrtc packate for web proxiesWe're currently using version `0.0.62`. I tried an update to the current version `0.4.4` and it works. Let's update to make these a bit more secure.We're currently using version `0.0.62`. I tried an update to the current version `0.4.4` and it works. Let's update to make these a bit more secure.Cecylia BocovichCecylia Bocovichhttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34050Restore check for nil writePipe in WebRTCPeer.Close2020-06-27T13:40:11ZDavid Fifielddcf@torproject.orgRestore check for nil writePipe in WebRTCPeer.CloseI removed this check in [047d3214bfb46de07e5d9f223e4fb1ba24584c8a](https://gitweb.torproject.org/pluggable-transports/snowflake.git/commit/?id=047d3214bfb46de07e5d9f223e4fb1ba24584c8a) because `NewWebRTCPeer` always initializes `writePip...I removed this check in [047d3214bfb46de07e5d9f223e4fb1ba24584c8a](https://gitweb.torproject.org/pluggable-transports/snowflake.git/commit/?id=047d3214bfb46de07e5d9f223e4fb1ba24584c8a) because `NewWebRTCPeer` always initializes `writePipe`, and it is never reset to `nil`. However tests used `&WebRTCPeer{}` which bypasses `NewWebRTCPeer` and leaves `writePipe` set to `nil`.
From comment:3:ticket:34049.David Fifielddcf@torproject.orgDavid Fifielddcf@torproject.orghttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34049Fix proxy calls to session description serialization utils2020-06-27T13:40:11ZCecylia BocovichFix proxy calls to session description serialization utilsWhoops, the proxy code wasn't updated after legacy/trac#33897Whoops, the proxy code wasn't updated after legacy/trac#33897Cecylia BocovichCecylia Bocovichhttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34042Reduce DataChannelTimeout2020-06-27T13:40:11ZDavid Fifielddcf@torproject.orgReduce DataChannelTimeoutSince legacy/trac#33897 we have separate timeout controls for first establishing the data channel (`DataChannelTimeout`) and deciding a once-working data channel has died (`SnowflakeTimeout`). They are both currently set to 30 s. We can ...Since legacy/trac#33897 we have separate timeout controls for first establishing the data channel (`DataChannelTimeout`) and deciding a once-working data channel has died (`SnowflakeTimeout`). They are both currently set to 30 s. We can lower `DataChannelTimeout` to discard non-working proxies more quickly.https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34002Remove Snowflake interface, use *WebRTCPeer directly2020-06-27T13:40:11ZDavid Fifielddcf@torproject.orgRemove Snowflake interface, use *WebRTCPeer directlyThe other interfaces in client/lib/interfaces.go exist for the purpose of running tests, but not `Snowflake`. Existing code would not have worked with other types anyway, because it does unchecked `.(*WebRTCPeer)` conversions.The other interfaces in client/lib/interfaces.go exist for the purpose of running tests, but not `Snowflake`. Existing code would not have worked with other types anyway, because it does unchecked `.(*WebRTCPeer)` conversions.David Fifielddcf@torproject.orgDavid Fifielddcf@torproject.orghttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/33997Don't do a separate check for a short write2020-06-27T13:40:11ZDavid Fifielddcf@torproject.orgDon't do a separate check for a short writeMinor refactoring in the course of doing legacy/trac#33897.Minor refactoring in the course of doing legacy/trac#33897.David Fifielddcf@torproject.orgDavid Fifielddcf@torproject.orghttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/33996Simplify Peers.Pop2020-06-27T13:40:11ZDavid Fifielddcf@torproject.orgSimplify Peers.PopA minor refactoring that came up while working on legacy/trac#33897.A minor refactoring that came up while working on legacy/trac#33897.David Fifielddcf@torproject.orgDavid Fifielddcf@torproject.orghttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/33995Move pc.CreateOffer and pc.SetLocalDescription out of a goroutine2020-06-27T13:40:11ZDavid Fifielddcf@torproject.orgMove pc.CreateOffer and pc.SetLocalDescription out of a goroutineThis code was formerly the `OnNegotiationNeeded` handler before the switch on pion (comment:28:ticket:28942). We are blocking on `offerChannel` anyway, so we may as well run these operations synchronously and use a normal error return.This code was formerly the `OnNegotiationNeeded` handler before the switch on pion (comment:28:ticket:28942). We are blocking on `offerChannel` anyway, so we may as well run these operations synchronously and use a normal error return.David Fifielddcf@torproject.orgDavid Fifielddcf@torproject.orghttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/33994Remove now-unused Resetter interface2020-06-27T13:40:12ZDavid Fifielddcf@torproject.orgRemove now-unused Resetter interfaceThe `WaitForReset` method is unused since legacy/trac#33745 was merged.The `WaitForReset` method is unused since legacy/trac#33745 was merged.David Fifielddcf@torproject.orgDavid Fifielddcf@torproject.orghttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/33984Disable trickle ICE in client2020-06-27T13:40:12ZDavid Fifielddcf@torproject.orgDisable trickle ICE in clienthttps://gitweb.torproject.org/user/dcf/snowflake.git/commit/?h=no-trickle-ice&id=8bb114471572dea0c313d039626cc306a8b92cc8
As mentioned at
https://bugs.torproject.org/28942#comment:28
https://bugs.torproject.org/33157#comment:2https://gitweb.torproject.org/user/dcf/snowflake.git/commit/?h=no-trickle-ice&id=8bb114471572dea0c313d039626cc306a8b92cc8
As mentioned at
https://bugs.torproject.org/28942#comment:28
https://bugs.torproject.org/33157#comment:2David Fifielddcf@torproject.orgDavid Fifielddcf@torproject.orghttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/33982Simplify and refactor BytesSyncLogger2020-06-27T13:40:12ZDavid Fifielddcf@torproject.orgSimplify and refactor BytesSyncLoggerhttps://gitweb.torproject.org/user/dcf/snowflake.git/log/?h=refactor-byteslogger&id=73173cb6987dbf26fdb1036e4b7710c200f87141
https://gitweb.torproject.org/user/dcf/snowflake.git/diff/?h=refactor-byteslogger&id=73173cb6987dbf26fdb1036e4b7...https://gitweb.torproject.org/user/dcf/snowflake.git/log/?h=refactor-byteslogger&id=73173cb6987dbf26fdb1036e4b7710c200f87141
https://gitweb.torproject.org/user/dcf/snowflake.git/diff/?h=refactor-byteslogger&id=73173cb6987dbf26fdb1036e4b7710c200f87141&id2=65ecb798ca8842a431214c2aa5133620e576c5f3
No longer needs a separate `go logger.Log()` in the caller.David Fifielddcf@torproject.orgDavid Fifielddcf@torproject.orghttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/33897Remove buffering from WebRTCPeer2022-11-14T14:28:29ZDavid Fifielddcf@torproject.orgRemove buffering from WebRTCPeer`WebRTCPeer` has a `buffer` that is used to hold bytes until the data channel is connected. We should remove it after the turbotunnel changes are merged (legacy/trac#33745). What ends up happening is the reliability layer ends up retrans...`WebRTCPeer` has a `buffer` that is used to hold bytes until the data channel is connected. We should remove it after the turbotunnel changes are merged (legacy/trac#33745). What ends up happening is the reliability layer ends up retransmitting packets as they sit in the buffer, and when the data channel is finally established, all those old useless packets get sent in a mass. It's better to just drop those packets on the floor before the data channel exists.David Fifielddcf@torproject.orgDavid Fifielddcf@torproject.org