Skip to content

GitLab

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Closed
Created by David Fifield@dcfOwner

Add command-line options for unsafe logging

Moved from comment:4:ticket:33157

Something like that patch was useful when working on legacy/trac#19026 (moved) so would you consider merging, https://github.com/keroserene/snowflake/commit/dbd733e4b1430c046ec11e8052efdbac6010e58a

It's okay with me but I would call the option --unsafe-logging instead of --unsafeLogging to match the style of the other options.

In broker/broker.go, yes, dashes are used (ex. disable-tls, acme-email, etc), however, in client/snowflake.go we have camel casing (ex. logToStateDir, keepLocalAddresses, etc)

We should probably consolidate this now. I imagine your preference is for the former?