Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • S Snowflake
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 70
    • Issues 70
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Anti-censorship
  • Pluggable Transports
  • Snowflake
  • Issues
  • #33665

Closed
Open
Created Mar 19, 2020 by David Fifield@dcfOwner

Add command-line options for unsafe logging

Moved from comment:4:ticket:33157

Something like that patch was useful when working on legacy/trac#19026 (moved) so would you consider merging, https://github.com/keroserene/snowflake/commit/dbd733e4b1430c046ec11e8052efdbac6010e58a

It's okay with me but I would call the option --unsafe-logging instead of --unsafeLogging to match the style of the other options.

In broker/broker.go, yes, dashes are used (ex. disable-tls, acme-email, etc), however, in client/snowflake.go we have camel casing (ex. logToStateDir, keepLocalAddresses, etc)

We should probably consolidate this now. I imagine your preference is for the former?

Assignee
Assign to
Time tracking