Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P pluggable transports
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 5
    • Issues 5
    • List
    • Boards
    • Service Desk
    • Milestones
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Jobs
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Anti-censorship
  • Pluggable Transports
  • pluggable transports
  • Issues
  • #12190
Closed
Open
Created Jun 03, 2014 by Trac@tracbot

Pyptlib does not join args or optargs correctly in ClientTransportPlugin.reportMethodSuccess

In ClientTransportPlugin.reportMethodSuccess, the code for joining the params args and optargs is wrong. The args and optargs params are defined as strings when they should be lists of strings. Current code {{{#!python if args and len(args) > 0: methodLine = methodLine + ' ARGS=' + args.join(',') if optArgs and len(optArgs) > 0: methodLine = methodLine + ' OPT-ARGS=' + args.join(',') }}}

Fixed Code {{{#!python if args and len(args) > 0: methodLine = methodLine + ' ARGS=' + ','.join(args) if optArgs and len(optArgs) > 0: methodLine = methodLine + ' OPT-ARGS=' + ','.join(optArgs) }}} Also the documentation for the types of args and optArgs should be changed to lists.

Trac:
Username: RushingWookie

Assignee
Assign to
Time tracking