Skip to content
  • MozLando's avatar
    Merge #8222 #8226 · a64c6849
    MozLando authored
    8222: Move and link top sites feature RFC. r=jonalmeida a=pocmo
    
    
    
    8226: Closes #8209 - Use new onTouchEventForResult GV api r=pocmo a=Mugurell
    
    Changes:
    - previously NestedGV#onTouchEvent event would call onTouchEventForResult where
    we would make possible the integration of GV in CoordinatorLayout.
    Since NestedGV#onTouchEvent does not anymore call onTouchEventForResult I've
    moved all code in onTouchEvent and then call onTouchEventForResult only for
    ACTION_DOWN events as snorp recommended.
    - we now must wait for onTouchEventForResult#GeckoResult<Int> and only then
    call startNestedScroll(..) since otherwise when executing that method in
    BrowserToolbarBottomBehavior we would return false since the MotionEvent is
    at that time unhandled.
    - only dispatch startNestedScroll and dispatchNestedPreScroll if GV returned
    INPUT_RESULT_HANDLED.
    
    In testing I saw most of the times GeckoResult resolves in < 5ms with bigger
    timeouts showing a logarithmic growth. As such I think the change should be
    imperceptible to users.
    
    [video showing the same as before behavior in Fenix](https://drive.google.com/file/d/1WiQ5bXb-dBxYDA03snYSkxApxfhr7hgQ/view?usp=sharing
    
    )
    
    
    
    Co-authored-by: default avatarSebastian Kaspari <s.kaspari@gmail.com>
    Co-authored-by: default avatarMugurell <Mugurell@users.noreply.github.com>
    a64c6849