Skip to content
GitLab
Menu
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
The Tor Project
Applications
android-components
Commits
0a742910
Commit
0a742910
authored
Nov 25, 2019
by
Jonathan Almeida
Browse files
Closes #5144: Fix GeckoWebPushHandler API signature update
parent
dcf5287e
Changes
4
Hide whitespace changes
Inline
Side-by-side
buildSrc/src/main/java/Gecko.kt
View file @
0a742910
...
...
@@ -6,7 +6,7 @@ internal object GeckoVersions {
/**
* GeckoView Nightly Version.
*/
const
val
nightly_version
=
"72.0.201911
19043902
"
const
val
nightly_version
=
"72.0.201911
25095200
"
/**
* GeckoView Beta Version.
...
...
components/browser/engine-gecko-nightly/src/main/java/mozilla/components/browser/engine/gecko/webpush/GeckoWebPushHandler.kt
View file @
0a742910
...
...
@@ -19,8 +19,8 @@ internal class GeckoWebPushHandler(
/**
* See [WebPushHandler].
*/
override
fun
onPushMessage
(
s
ubscription
:
WebPushSubscription
,
message
:
ByteArray
?)
{
runtime
.
webPushController
.
onPushEvent
(
s
ubscription
.
toGeckoSubscription
()
,
message
)
override
fun
onPushMessage
(
s
cope
:
String
,
message
:
ByteArray
?)
{
runtime
.
webPushController
.
onPushEvent
(
s
cope
,
message
)
}
/**
...
...
components/browser/engine-gecko-nightly/src/test/java/mozilla/components/browser/engine/gecko/webpush/GeckoWebPushHandlerTest.kt
View file @
0a742910
...
...
@@ -39,7 +39,7 @@ class GeckoWebPushHandlerTest {
ByteArray
(
16
)
)
handler
.
onPushMessage
(
subscription
,
null
)
handler
.
onPushMessage
(
""
,
null
)
verify
(
controller
).
onPushEvent
(
any
(),
isNull
())
...
...
components/concept/engine/src/main/java/mozilla/components/concept/engine/webpush/WebPush.kt
View file @
0a742910
...
...
@@ -16,10 +16,10 @@ interface WebPushHandler {
/**
* Invoked when a push message has been delivered.
*
* @param s
ubscription A [WebPushSubscription] for the messaged delivered
.
* @param s
cope The subscription identifier which usually represents the website's URI
.
* @param message A [ByteArray] message.
*/
fun
onPushMessage
(
s
ubscription
:
WebPushSubscription
,
message
:
ByteArray
?)
fun
onPushMessage
(
s
cope
:
String
,
message
:
ByteArray
?)
/**
* Invoked when a subscription has now changed/expired.
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment