Verified Commit 3ddffe61 authored by Alex Catarineu's avatar Alex Catarineu Committed by Pier Angelo Vendrame
Browse files

Bug 40002: Ensure system download manager is not used 

Bug 40075: Support scoped storage to enable downloads on API < 29

- in android-components!7,  we blocked all usage of Scoped
  Storage in an attempt to block usage of Android's
  DownloadManager, which is known to cause proxy bypasses
- as of Android API 29, downloads will not work without Scoped Storage,
  causing all downlaods to fail (see: fenix##40192)
- here, we enable usage of scoped storage for API >= 29, but block
  calls to DownloadManager on API < 29
parent f980f6cf

components/feature/downloads/src/main/java/mozilla/components/feature/downloads/DownloadsFeature.kt

+1 −2
Original line number Diff line number Diff line
@@ -25,7 +25,6 @@ import mozilla.components.browser.state.state.SessionState 
import mozilla.components.browser.state.state.content.DownloadState

import mozilla.components.browser.state.store.BrowserStore

import mozilla.components.feature.downloads.DownloadDialogFragment.Companion.FRAGMENT_TAG

import mozilla.components.feature.downloads.manager.AndroidDownloadManager

import mozilla.components.feature.downloads.manager.DownloadManager

import mozilla.components.feature.downloads.manager.noop

import mozilla.components.feature.downloads.manager.onDownloadStopped
@@ -70,7 +69,7 @@ class DownloadsFeature( 
    internal val useCases: DownloadsUseCases,

    override var onNeedToRequestPermissions: OnNeedToRequestPermissions = { },

    onDownloadStopped: onDownloadStopped = noop,

    private val downloadManager: DownloadManager = AndroidDownloadManager(applicationContext, store),

    private val downloadManager: DownloadManager,

    private val tabId: String? = null,

    private val fragmentManager: FragmentManager? = null,

    private val promptsStyling: PromptsStyling? = null,